Page MenuHome

Fix T83266: Proxy building with meta strips fails
ClosedPublic

Authored by Richard Antalik (ISS) on Jan 5 2021, 11:10 AM.

Details

Summary

Building proxy with meta strip selected resulted in attempt to render
meta strip itself and save result as image as is done when building
image proxies.

Remove meta strip from list of supported strips.

Multicam, Meta and scene strip are cleared from poll function in UI as well.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jan 5 2021, 11:10 AM
Richard Antalik (ISS) created this revision.
Sergey Sharybin (sergey) requested changes to this revision.Jan 12 2021, 9:43 AM

I haven't checked how this worked originally

But this is something important to know.

Building proxies with meta strips should recurse into meta strip

While it sounds reasonable, the interface is wrong then. Meta strip has proxy and timecode settings. So if proxy on a meta level is not possible, then the settings needs to be hidden from user.

This revision now requires changes to proceed.Jan 12 2021, 9:43 AM

I haven't checked how this worked originally

But this is something important to know.

I will try to check, but I am not sure where to start even. I remember 2.79 code to be quite messy and it was sculpted bit after bit into current shape. I am not sure if 2.79 code can be used as reference that is working as intended.

Building proxies with meta strips should recurse into meta strip

While it sounds reasonable, the interface is wrong then. Meta strip has proxy and timecode settings. So if proxy on a meta level is not possible, then the settings needs to be hidden from user.

I wouldn't disagree here, I guess this was meant to be convinient to build proxies inside metas recursively from top seqbase.
However if I hide build proxies button for metas, I would have to disallow recursive proxy building as well, so it is consistent.

Perhaps this could be handled better by UI to inform user that it will build proxies recursively, not sure.

I remember 2.79 code to be quite messy and it was sculpted bit after bit into current shape.

You don't need to check code: do a user-level check. Shouldn't take too much time.

However if I hide build proxies button for metas, I would have to disallow recursive proxy building as well, so it is consistent.

If the meta-level proxy is not implemented (at some point in time the idea was to create proxy for meta strip to act as some sort of cache), then it is better not to recurse inside. Meta strip can consist of many strips, and you wouldn't want to rebuild proxy for all of them.

I remember 2.79 code to be quite messy and it was sculpted bit after bit into current shape.

You don't need to check code: do a user-level check. Shouldn't take too much time.

However if I hide build proxies button for metas, I would have to disallow recursive proxy building as well, so it is consistent.

If the meta-level proxy is not implemented (at some point in time the idea was to create proxy for meta strip to act as some sort of cache), then it is better not to recurse inside. Meta strip can consist of many strips, and you wouldn't want to rebuild proxy for all of them.

Yes so up to 2.79 proxies could be rendered with per-project setting, otherwise it did nothing. Now disk cache should be used to make preview faster.
So I won't do this recursion.

  • Remove proxy panel from scene meta and multicam strips
Richard Antalik (ISS) edited the summary of this revision. (Show Details)Jan 21 2021, 4:26 AM

Multicam and scene strip are cleared from poll function in UI as well.

So is Scene strips. As in, description needs some update.

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Jan 21 2021, 3:17 PM

Multicam and scene strip are cleared from poll function in UI as well.

So is Scene strips. As in, description needs some update.

I think you meant meta?

I think you meant meta?

Ah yes. Sorry. Managed to mis-read simple sentence. Just felt that there was something missing between what code did and what was stated in the description for some reason.

Was actually all fine.

This revision is now accepted and ready to land.Jan 21 2021, 3:27 PM