Page MenuHome

Fix T84142: crash when mirroring hair emitted from vertices
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Jan 5 2021, 12:38 PM.

Details

Summary

The hair mirroring code seems to expect that hair is emitted from faces. The PE_mirror_x contains the following expression: mirrorfaces[pa->num * 2]. This only makes sense when pa->num is a face index.

The simplest short term solution is to disable the mirror operator when the particles haven't been emitted from faces.

Diff Detail

Repository
rB Blender
Branch
fix-mirror-hair (branched from master)
Build Status
Buildable 11994
Build 11994: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 5 2021, 12:38 PM
Jacques Lucke (JacquesLucke) created this revision.

Not sure who to add as reviewer. Just adding you two to check if I missed something obvious.

I think this is reasonable as we are going to rework the hair system either way, right?

LGTM

@Philipp Oeser (lichtwerk) any objections?

This revision is now accepted and ready to land.Jan 5 2021, 6:29 PM

Fine with me.

Not totally sure on the policy of usage, but we could spit out some hint why it is disabled using CTX_wm_operator_poll_msg_set I think? (since it it not so obvious here...)
But fine even without it.