[WIP] Fix T84398: Multiview images show only one view
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 5 2021, 1:17 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T84398: Multiview images show only one view

Summary

Caused by rBd6525e8d133b.

In the case of 'Multi-View' Stereoscopy, the view index is stored in
ImageUser->view (in contrast to 'Stereo 3D' mode where it is stored in
ImageUser->multiview_eye), but as soon as the IMA_SHOW_STEREO flag was
set, only multiview_eye was considered.

Now do as is done elsewhere and also check BKE_image_is_stereo(ima) to
use ->multiview_eye, use ->view otherwise.

That being said, this patch will use the right view selected from the
menu now, but introduces a crash sometimes in binding the texture which
I will still have to investigate.

Diff Detail

Repository

rB Blender

Branch

T84398 (branched from master)

Build Status

Buildable 11996
Build 11996: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 5 2021, 1:17 PM

Harbormaster completed remote builds in B11996: Diff 32455.Jan 5 2021, 1:17 PM

Philipp Oeser (lichtwerk) requested review of this revision.Jan 5 2021, 1:17 PM

Philipp Oeser (lichtwerk) added projects: Images & Movies, EEVEE & Viewport.Jan 5 2021, 1:18 PM

@Jeroen Bakker (jbakker) : not sure if it makes sense for me hunting further, it seems wrong to use the Image User multi_index [which is stored in iuser->view here] to get the texture with get_image_gpu_texture_ptr.
I mean it does work, but has the mentioned crashes :/

Maybe you know right away? Want to take over?

Philipp Oeser (lichtwerk) mentioned this in T84398: Multiview images show only one view.Jan 5 2021, 3:21 PM

A fix has been committed, see rBebaa3fcedd23: Fix T84398: Multiview images show only one view.