Fix T83497: missing relations update when group node changes
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 6 2021, 3:11 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T83497: Drivers not updating for nodes in node groups when created through python until dependencies manually updated

Commits

rBc26f46cb9521: Fix T83497: missing relations update when group node changes

Summary

Changing which node group a group node references, needs a depsgraph relations update in some cases.
An example for where this is necessary can be found in T83497.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 6 2021, 3:11 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B12018: Diff 32487.Jan 6 2021, 3:11 PM

Jacques Lucke (JacquesLucke) added a task: T83497: Drivers not updating for nodes in node groups when created through python until dependencies manually updated.Jan 6 2021, 3:12 PM

better fix

Harbormaster completed remote builds in B12020: Diff 32489.Jan 6 2021, 3:23 PM

Jacques Lucke (JacquesLucke) retitled this revision from Fix T83497: missing relations update after adding node to Fix T83497: missing relations update when group node changes.Jan 6 2021, 3:27 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

The logic makes sense and it's a simple fix, and looking at other uses of DEG_relations_tag_update it doesn't seem out of the ordinary.

This revision is now accepted and ready to land.Jan 6 2021, 6:46 PM

Closed by commit rBc26f46cb9521: Fix T83497: missing relations update when group node changes (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 7 2021, 1:31 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBc26f46cb9521: Fix T83497: missing relations update when group node changes.

Charlie Jolly (charlie) mentioned this in T87167: Object dragged from Outliner into Geo Nodes doesn't auto update.Apr 9 2021, 4:07 PM