Page MenuHome

Use the term "N-gon" instead of "Polygon" for triangulation method
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jan 6 2021, 4:27 PM.

Details

Summary

This was reported for the Triangulate geometry node, but was also true
for the triangulate modifier and in exporters.

Note the modifier was introduced with "Ngon Method" in rBa7b44c82e5b9 but
was renamed to "Polygon Method" in rBf4762eb12ba5.

Since quads are also polygons (and quads have their own method), the
term "N-gon" is more appropriate here and is also described in the
glossary https://docs.blender.org/manual/en/2.92/glossary/
index.html#term-N-gon

Docs have been updated in rBM7539 (partially - the method would also
have to be renamed once this patch lands).

Note this also fixes the wrong enum used for the alembic exporter.

Fixes T83907

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jan 6 2021, 4:27 PM
Philipp Oeser (lichtwerk) created this revision.

LGTM

Not sure why you added @Sybren A. Stüvel (sybren) as reviewer here though? AFAIK he is neither UI nor Modifier team member?

This revision is now accepted and ready to land.Jan 6 2021, 5:12 PM

LGTM

Not sure why you added @Sybren A. Stüvel (sybren) as reviewer here though? AFAIK he is neither UI nor Modifier team member?

This is because it changes the enum used in the alembic exporter [which was wrong I think]

LGTM

Not sure why you added @Sybren A. Stüvel (sybren) as reviewer here though? AFAIK he is neither UI nor Modifier team member?

This is because it changes the enum used in the alembic exporter [which was wrong I think]

Ah right, makes sense indeed then. :)

@Sybren A. Stüvel (sybren): this also passes the alembic tests:

$ ctest -R alembic
Test project /localpath/build_linux
    Start 58: alembic_export_tests
1/2 Test #58: alembic_export_tests .............   Passed    5.94 sec
    Start 59: script_alembic_io
2/2 Test #59: script_alembic_io ................   Passed    0.33 sec

100% tests passed, 0 tests failed out of 2