Page MenuHome

Addon: Bolt Factory: Corrected "Change Bolt" removes linked duplicates
ClosedPublic

Authored by Robert Meerman (meermanr) on Jan 7 2021, 6:37 PM.

Details

Summary

Prior to this patch, attempting to modify an existing bolt would
*replace* the object's mesh data block with a new one and remove the
original. This removal would essentially delete all linked duplicates.

Now the original mesh data block is modified in place, which avoids
having to copy anything between new and old object data blocks
(materials, names, etc), and causes all linked duplicates to reflect
the changes as users would expect.

Diff Detail

Event Timeline

Robert Meerman (meermanr) requested review of this revision.Jan 7 2021, 6:37 PM
Robert Meerman (meermanr) created this revision.
Robert Meerman (meermanr) added a comment.EditedJan 8 2021, 11:09 AM

Video demonstrating how linked duplicates are removed when using "Change Bolt"

This revision is now accepted and ready to land.Jan 8 2021, 12:03 PM

This patch has an approved status yet it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect that. This way the patch show as pending still.

This revision now requires review to proceed.Mar 26 2021, 5:23 PM

Thanks for the Patch meermanr

Sorry for the delay in the commit

This revision is now accepted and ready to land.Feb 6 2022, 10:52 PM

Thanks for the Patch meermanr
Committed in 6b131222ad25