Differential D10035
Addon: Bolt Factory: Corrected resource leak when adding in EDIT mode Authored by Robert Meerman (meermanr) on Jan 7 2021, 6:39 PM.
Details Addon: Bolt Factory: Corrected resource leak when adding in EDIT mode Adding a bolt while in edit mode would *replace* the current object's mesh data block with a new one, and then fail to remove the original mesh data block. Now the original mesh is updated in-place, preserving its name and avoiding orphan data blocks.
Diff Detail
Event TimelineComment Actions Video showing how the original mesh data block becomes orphaned by adding a Bolt in edit mode, and how the object's mesh is replaced with one with an unexpected name. Comment Actions Thanks for your work! Comment Actions @Vladimir Spivak (cwolf3d) I'm not sure if you meant the same, but you should commit on their behalf so they get the credit (see the wiki for instructions). Comment Actions This patch has an approved status yet it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect that. This way the patch show as pending still. Comment Actions I'm getting an error testing this on Blender 3.0 It maybe an API change since this patch was made bmesh.update_edit_mesh(obj.data, True, True) # Flush changes (update edit mode's view) Comment Actions OK the fix is this bmesh.update_edit_mesh(obj.data) # Flush changes (update edit mode's view) |