Addon: Bolt Factory: Shade smooth with auto-smoothing by default
Needs ReviewPublic
Actions

Authored by Robert Meerman (meermanr) on Jan 7 2021, 6:43 PM.

Details

Reviewers

Spuds (SpudsTheMann)
Vladimir Spivak (cwolf3d)

Summary

I assume I am not alone in applying "Shade Smooth" and "Normals > Auto Smooth" to bolts and nuts created by Bolt Factory.

This patch makes smooth with auto-smoothing the default.

User can opt-out by using "Shade Flat" and/or disabling "Normals > Auto Smooth".

Diff Detail

Event Timeline

Robert Meerman (meermanr) requested review of this revision.Jan 7 2021, 6:43 PM

Robert Meerman (meermanr) created this revision.

Robert Guetzkow (rjg) edited reviewers, added: Add-ons (Community); removed: Robert Guetzkow (rjg).Jan 7 2021, 7:34 PM

Vladimir Spivak (cwolf3d) accepted this revision.Jan 8 2021, 12:04 PM

This revision is now accepted and ready to land.Jan 8 2021, 12:04 PM

@Robert Guetzkow (rjg) please DO NOT add whole generic projects like that as reviewers, you are spamming hundreds of people otherwise!

Sorry, that was probably me! I was just trying to follow the advice I got in #blender-coders (below). Won't happen again

Just tag it add-ons, check the git history of the file, add them as reviewers (although you don't have to do that - just suggestion).

@Robert Meerman (meermanr) No, that was my fault. I added the module when I removed myself as reviewer.
@Bastien Montagne (mont29) Sorry about that! I didn't realize this would notify everybody in the module.

This patch has an approved status yet it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect that. This way the patch show as pending still.

This revision now requires review to proceed.Mar 26 2021, 5:19 PM

Revision Contents
Changeset List

Path

Size

add_mesh_BoltFactory/

Boltfactory.py

2 lines

Diff 32520

View Options

add_mesh_BoltFactory/Boltfactory.py

Addon: Bolt Factory: Shade smooth with auto-smoothing by defaultNeeds ReviewPublicActions