Page MenuHome
Differential D10039

Addon: Bolt Factory: Reorder presets in UI
ClosedPublic
Actions

Authored by Robert Meerman (meermanr) on Jan 7 2021, 6:44 PM.

Details

Reviewers
Aaron Keith (spudmn)
Vladimir Spivak (cwolf3d)
Commits
rBA713854cc2b23: Reorder presets in UI
Summary

This changes the order in which presets are shown by the "Add Bolt" operator such that they follow natural numeric ordering.

Before:

  • Default
  • M10
  • M12
  • M2
  • M3
  • M4
  • M5
  • M6
  • M8

After:

  • Default
  • M2
  • M3
  • M4
  • M5
  • M6
  • M8
  • M10
  • M12

Diff Detail

Event Timeline

Robert Meerman (meermanr) requested review of this revision.Jan 7 2021, 6:44 PM
Robert Meerman (meermanr) created this revision.
Robert Guetzkow (rjg) edited reviewers, added: Add-ons (Community); removed: Robert Guetzkow (rjg).Jan 7 2021, 7:34 PM
Vladimir Spivak (cwolf3d) accepted this revision.Jan 8 2021, 12:04 PM
This revision is now accepted and ready to land.Jan 8 2021, 12:04 PM
Bastien Montagne (mont29) removed a reviewer: Add-ons (Community).Jan 8 2021, 12:38 PM
Dalai Felinto (dfelinto) added 1 blocking reviewer(s): Aaron Keith (spudmn).Mar 26 2021, 5:19 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

This patch has an approved status yet it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect that. This way the patch show as pending still.

This revision now requires review to proceed.Mar 26 2021, 5:19 PM
Aaron Keith (spudmn) accepted this revision.Mar 29 2021, 7:27 AM

Looks good to me.
Thanks for the patch.

This revision is now accepted and ready to land.Mar 29 2021, 7:27 AM
Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).Feb 4 2022, 9:32 AM

So, is anybody going to commit this?

Aaron Keith (spudmn) added a comment.EditedFeb 6 2022, 8:09 AM
In D10039#372934, @Raimund Klink (Raimund58) wrote:

So, is anybody going to commit this?

I did a commit for this today. I hope I did it right.

713854cc2b23

I'm not sure if I am meant to close this patch some how?

Aaron Keith (spudmn) added a commit: rBA713854cc2b23: Reorder presets in UI.Feb 6 2022, 8:19 AM
Aaron Keith (spudmn) closed this revision.Feb 6 2022, 8:35 AM

Revision Contents
Changeset List

PathSize
presets/
operator/
mesh.bolt_add/
_default.py
default.py
_m3.py
m3.py
_m4.py
m4.py
_m5.py
m5.py
_m6.py
m6.py
_m8.py
m8.py

Diff 32521

View Options

presets/operator/mesh.bolt_add/_default.py

Loading...
View Options

presets/operator/mesh.bolt_add/_m3.py

Loading...
View Options

presets/operator/mesh.bolt_add/_m4.py

Loading...
View Options

presets/operator/mesh.bolt_add/_m5.py

Loading...
View Options

presets/operator/mesh.bolt_add/_m6.py

Loading...
View Options

presets/operator/mesh.bolt_add/_m8.py

Loading...
View Options

presets/operator/mesh.bolt_add/default.py

Loading...
View Options

presets/operator/mesh.bolt_add/m3.py

Loading...
View Options

presets/operator/mesh.bolt_add/m4.py

Loading...
View Options

presets/operator/mesh.bolt_add/m5.py

Loading...
View Options

presets/operator/mesh.bolt_add/m6.py

Loading...
View Options

presets/operator/mesh.bolt_add/m8.py

Loading...