Surface Deform: optimize memory allocation in the evaluation code.
ClosedPublic
Actions

Authored by Alexander Gavrilov (angavrilov) on Jan 7 2021, 7:10 PM.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rB662b7c3edfcd: Surface Deform: optimize memory allocation in the evaluation code.

Summary

Using malloc to allocate a temporary array for each vertex,
which most commonly contains just 4 elements, is not efficient.
Checking the mode with a switch is also better.

Finally, a one line UI fix: the strength option is not bind specific.

Diff Detail

Repository

rB Blender

Branch

temp-angavrilov-sdef-optimize (branched from master)

Build Status

Buildable 12039
Build 12039: arc lint + arc unit

Event Timeline

Alexander Gavrilov (angavrilov) created this revision.Jan 7 2021, 7:10 PM

Harbormaster completed remote builds in B12039: Diff 32526.Jan 7 2021, 7:10 PM

Alexander Gavrilov (angavrilov) requested review of this revision.Jan 7 2021, 7:10 PM

Daniel Ulrich (dulrich) awarded a token.Jan 7 2021, 7:43 PM

Nice, TIL about both __builtin_expect and __builtin_alloca.

I tested this locally, and at least for the common case it seems to work. I couldn't figure out how to trip the big_buffer condition.

Out of curiosity, did you do any bench-marking around how big an impact this has?

Also, the UI change seems pretty unrelated, could we split that into a separate patch just to keep patches single-purpose?

LGTM, UI change should be committed separately though.

This revision is now accepted and ready to land.Jan 8 2021, 10:12 AM

Closed by commit rB662b7c3edfcd: Surface Deform: optimize memory allocation in the evaluation code. (authored by Alexander Gavrilov (angavrilov)). · Explain WhyJan 8 2021, 10:25 AM

This revision was automatically updated to reflect the committed changes.

Alexander Gavrilov (angavrilov) added a commit: rB662b7c3edfcd: Surface Deform: optimize memory allocation in the evaluation code..

Alexander Gavrilov (angavrilov) mentioned this in rB8877e294dfd6: Surface Deform: the Strength setting is not bind-specific..

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_surfacedeform.c

43 lines

Diff 32526

View Options

source/blender/modifiers/intern/MOD_surfacedeform.c

Surface Deform: optimize memory allocation in the evaluation code.ClosedPublicActions