Forbid deleting last local scene.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 8 2021, 3:56 PM.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rBbc788929aa2b: Scenes: forbid deleting last local scene

Summary

Previously, it was only forbidden to delete the last scene. This can lead to the situation where a .blend file only contains linked scenes. This is problematic, because linked data might not always be available or can be removed from a .blend file without having an additional check for remaining scenes.

Diff Detail

Repository

rB Blender

Branch

forbid-deleting-last-local-scene (branched from master)

Build Status

Buildable 12052
Build 12052: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 8 2021, 3:56 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B12052: Diff 32549.Jan 8 2021, 3:56 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 8 2021, 4:00 PM

use better fix

Harbormaster completed remote builds in B12053: Diff 32550.Jan 8 2021, 4:08 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 8 2021, 4:09 PM

Jacques Lucke (JacquesLucke) added a reviewer: Bastien Montagne (mont29).

Bastien Montagne (mont29) accepted this revision.Jan 8 2021, 4:18 PM

Bastien Montagne (mont29) added inline comments.

source/blender/blenkernel/intern/scene.c
2038 ↗	(On Diff #32550)	just pass `scene`, the macro converts to `(ID *)` anyway.
source/blender/makesrna/intern/rna_main_api.c
220 ↗	(On Diff #32550)	`local one`