Page MenuHome
Differential D10049

Forbid deleting last local scene.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 8 2021, 3:56 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rBbc788929aa2b: Scenes: forbid deleting last local scene
Summary

Previously, it was only forbidden to delete the last scene. This can lead to the situation where a .blend file only contains linked scenes. This is problematic, because linked data might not always be available or can be removed from a .blend file without having an additional check for remaining scenes.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 8 2021, 3:56 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B12052: Diff 32549.Jan 8 2021, 3:56 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 8 2021, 4:00 PM
Jacques Lucke (JacquesLucke) updated this revision to Diff 32550.Jan 8 2021, 4:08 PM
  • use better fix
Harbormaster completed remote builds in B12053: Diff 32550.Jan 8 2021, 4:08 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 8 2021, 4:09 PM
Jacques Lucke (JacquesLucke) added a reviewer: Bastien Montagne (mont29).
Bastien Montagne (mont29) accepted this revision.Jan 8 2021, 4:18 PM
Bastien Montagne (mont29) added inline comments.
source/blender/blenkernel/intern/scene.c
2038

just pass scene, the macro converts to (ID *) anyway.

source/blender/makesrna/intern/rna_main_api.c
219–222

local one

This revision is now accepted and ready to land.Jan 8 2021, 4:18 PM
Jacques Lucke (JacquesLucke) mentioned this in D10046: Fix T83592: Crash when deleting or reloading linked scene..Jan 8 2021, 4:26 PM
Closed by commit rBbc788929aa2b: Scenes: forbid deleting last local scene (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 8 2021, 4:40 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBbc788929aa2b: Scenes: forbid deleting last local scene.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
intern/
15 lines
editors/
scene/
3 lines
makesrna/
intern/
10 lines

Diff 32553

View Options

source/blender/blenkernel/BKE_scene.h

Loading...
View Options

source/blender/blenkernel/intern/scene.c

Loading...
View Options

source/blender/editors/scene/scene_edit.c

Loading...
View Options

source/blender/makesrna/intern/rna_main_api.c

Loading...