Page MenuHome

Fix detection for OpenSUSE and other distributions (that are not deb, arch or rpm-based) like Slackware
AbandonedPublic

Authored by Mohamed AMAZIRH (m.amazirh) on Jan 10 2021, 9:03 AM.

Details

Reviewers
None
Summary
  • install_deps.sh checks the presence of /etc/SuSE-release to detect OpenSUSE. OpenSUSE deprecated the use of /etc/SuSE-release since 13.1, and removed it in Leap 15.0. /etc/os-release should be used instead. (os-release was already used in install_deps.sh but only to build packman repo's url). See https://en.opensuse.org/Etc_SuSE-release
  • Other distributions (that are not deb, arch or rpm based) like Slackware are always detected as an rpm distribution because of a faulty check [ -f /etc/redhat-release -o /etc/SuSE-release ] which always evaluates to true (because of a missing -f before /etc/SuSE-release). The fix for openSUSE's issue also fixes this point.
  • This commit also modifies the code used to build packman repo's url to take into account both OpenSUSE Leap and Tumbleweed (the urls for the two distributions do not use the same format).

Diff Detail

Repository
rB Blender
Branch
bugfix/mah/fix-opensuse-detection (branched from master)
Build Status
Buildable 12069
Build 12069: arc lint + arc unit

Event Timeline

Mohamed AMAZIRH (m.amazirh) requested review of this revision.Jan 10 2021, 9:03 AM
Mohamed AMAZIRH (m.amazirh) created this revision.

Sorry, I pushed the patch by mistake