Differential D10081

Geometry Nodes: New Align Rotation to Vector node.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 11 2021, 5:56 PM.

Tags

Subscribers

None

Details

Reviewers

Simon Thommes (simonthommes)
Hans Goudey (HooglyBoogly)

Maniphest Tasks

T83669: Align Rotation to Vector for tree leaves

Commits

rB3b77bd48f9c6: Geometry Nodes: new Align Rotation to Vector node

Summary

This adds a new Align Rotation to Vector node based on the mockup in T83669.

Diff Detail

Repository

Branch

align-rotation-to-vector (branched from master)

Build Status

Buildable 12117
Build 12117: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 11 2021, 5:56 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B12117: Diff 32634.Jan 11 2021, 5:56 PM

Jacques Lucke (JacquesLucke) added a project: Geometry Nodes.Jan 11 2021, 6:08 PM

Jacques Lucke (JacquesLucke) added a task: T83669: Align Rotation to Vector for tree leaves.

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added reviewers: Simon Thommes (simonthommes), Hans Goudey (HooglyBoogly).Jan 11 2021, 6:10 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

This worked nicely in my test.

source/blender/nodes/geometry/nodes/node_geo_align_rotation_to_vector.cc
85	I've been retrieving the span from attributes and then applying it afterwards because it should be slightly faster. Granted, the difference is probably negligible compared to all the matrix multiplication etc, but maybe it's worth being consistent.

This revision is now accepted and ready to land.Jan 11 2021, 10:47 PM

Found no issues in my tests.

Closed by commit rB3b77bd48f9c6: Geometry Nodes: new Align Rotation to Vector node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 12 2021, 12:55 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB3b77bd48f9c6: Geometry Nodes: new Align Rotation to Vector node.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

nodeitems_builtins.py

1 line

source/

blender/

blenkernel/

1 line

intern/

1 line

editors/

space_node/

13 lines

makesdna/

DNA_node_types.h

17 lines

makesrna/

intern/

41 lines

nodes/

1 line

1 line

NOD_static_types.h

1 line

geometry/

nodes/

node_geo_align_rotation_to_vector.cc

147 lines

Diff 32634

release/scripts/startup/nodeitems_builtins.py

Loading...

source/blender/blenkernel/BKE_node.h

Loading...

source/blender/blenkernel/intern/node.c

Loading...

source/blender/editors/space_node/drawnode.c

Loading...

source/blender/makesdna/DNA_node_types.h

Loading...

source/blender/makesrna/intern/rna_nodetree.c

Loading...

source/blender/nodes/CMakeLists.txt

Loading...

source/blender/nodes/NOD_geometry.h

Loading...

source/blender/nodes/NOD_static_types.h

Loading...

source/blender/nodes/geometry/nodes/node_geo_align_rotation_to_vector.cc

Loading...