Bmesh: Deprecate deform parameter of from_object()
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Jan 12 2021, 10:28 AM.

Details

Reviewers

Commits

rB4b0871af8716: Bmesh: Deprecate deform parameter of from_object()

Summary

The deform parameter of the Bmesh from_object method is deprecated,
always assumed to be True, and will be removed in the future.

That is because the cases where it is False don't work correctly and are
subject to memory leaks. One of the symptoms of the incorrect behavior
is the application of constructive modifiers twice if the input object
is an evaluated one, as demonstrated in D10053.

Diff Detail

Repository

rB Blender

Branch

deprecated-bmesh-from-object-deform (branched from master)

Build Status

Buildable 12136
Build 12136: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) requested review of this revision.Jan 12 2021, 10:28 AM

Omar Emara (OmarSquircleArt) created this revision.

Harbormaster completed remote builds in B12127: Diff 32657.Jan 12 2021, 10:28 AM

Merge branch 'master' into deprecated-bmesh-from-object-deform

Harbormaster completed remote builds in B12136: Diff 32675.Jan 12 2021, 1:34 PM

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Jan 14 2021, 7:08 AM

Aaron Carlisle (Blendify) added inline comments.

source/blender/python/bmesh/bmesh_py_types.c
1084	I would suggest using this syntax: https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-deprecated Also I think its a good idea to give a version when this will be removed.