It seems drivers for physics properties weren't being linked to
evaluation nodes. This connects settings used by modifiers
to Geometry; particle settings and rigid body data to Transform
which seems to contain rigid body evaluation; and force fields
to object Transform, since fields can exist on empties.
Details
Details
- Reviewers
Sergey Sharybin (sergey) Sybren A. Stüvel (sybren) - Group Reviewers
Physics
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- temp-angavrilov-depsgraph-physics (branched from master)
- Build Status
Buildable 12135 Build 12135: arc lint + arc unit
Event Timeline
Comment Actions
I just looked at Depsgraph As Image while working on D10064 and noticed that the driver nodes on physics properties have no output dependency links. Unless there is some magic built into the 'parameters' component, that would automatically mean things aren't working right, so I looked to fix it.
Comment Actions
Added links for drivers on rigid body object and constraint fields - it seems dynamically changing some of them may not actually work currently, but it should really.
Test file for use with Depsgraph To Image that I think should demonstrate all cases of drivers on physics properties:
Comment Actions
Test file for use with Depsgraph To Image
Do you have a test file of an actually failing case? Or does this just add lines to an image where you think lines should be?
Comment Actions
It would be extremely difficult to produce a 'failing case', because the potential failure mode here is a threaded race condition causing off-by-one-frame evaluation glitches.
Comment Actions
We've had such threading issues with the Rain rig (clothes being incorrect or downright disappearing in some situations).
If you really think this is impossible to test, at least show us some (crops of) depsgraph images, so that it's possible to see what the patch does without having to export and compare images before and after applying the patch.
Comment Actions
Generated a depsgraph image (manually edited to make the relevant relations into thick green lines).
