Page MenuHome

Fix T81965: Library-Override Not able to edit Keyframe properties
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Jan 12 2021, 1:52 PM.

Details

Summary

Fix keyframe properties not being editable when animating a
library-overridden datablock.

The problem was that RNA pointers were created based on the datablock
affected by the animation (for example an Object), instead of the
datablock that contains the FCurve itself (the Action). The latter can
be local to the current blend file and should thus be editable, even
when the former is not.

Diff Detail

Repository
rB Blender
Branch
temp-anim-liboverrides-T81965
Build Status
Buildable 12137
Build 12137: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Jan 12 2021, 1:52 PM

Code wise patch LGTM, am assuming you did proper testing here. :)

This revision is now accepted and ready to land.Jan 12 2021, 2:58 PM

For the record: I tested with the example file from T81965. With this patch it makes the relevant properties editable, and doesn't crash Blender. Saving and reloading the file also shows that the animation data was properly saved.