Differential D10110

Fix versioning for Set Alpha node
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Jan 14 2021, 1:28 PM.

Tags

None

Subscribers

None

Details

Reviewers

Jeroen Bakker (jbakker)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T84708: Set Alpha versioning code fails for nodes outside of node group

Commits

rBc399651637a3: Fix T84708: Versioning for Set Alpha node

Summary

This patch fixes T84708. The versioning code introduced in rB38df935c0985 skips the composite node tree that is used by the scene thus not correctly versioning Set Alpha nodes outside of node groups. This patch iterates through all node trees to version all Set Alpha nodes.

Diff Detail

Repository: rB Blender

Event Timeline

Robert Guetzkow (rjg) requested review of this revision.Jan 14 2021, 1:28 PM

Robert Guetzkow (rjg) created this revision.

Harbormaster completed remote builds in B12187: Diff 32773.Jan 14 2021, 1:28 PM

Add DNA check back that was missing in first patch

Harbormaster completed remote builds in B12188: Diff 32774.Jan 14 2021, 1:35 PM

Robert Guetzkow (rjg) mentioned this in T83353: Compositing: viewer node doesn't correctly preview 'set alpha' output.Jan 14 2021, 1:58 PM

Jacques Lucke (JacquesLucke) accepted this revision.Jan 25 2021, 4:41 PM

This revision is now accepted and ready to land.Jan 25 2021, 4:41 PM

Closed by commit rBc399651637a3: Fix T84708: Versioning for Set Alpha node (authored by Robert Guetzkow (rjg)). · Explain WhyJan 26 2021, 12:40 PM

This revision was automatically updated to reflect the committed changes.

Robert Guetzkow (rjg) added a commit: rBc399651637a3: Fix T84708: Versioning for Set Alpha node.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

versioning_290.c

3 lines

Diff 33147

source/blender/blenloader/intern/versioning_290.c

Loading...