Paths

Table of Contentst

Differential D10111

Subdiv: Use better default UV interpolation
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jan 14 2021, 4:07 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB3d3b6d94e6e6: Subdiv: Use better default UV interpolation

Summary

This change consists of several local commits, which are:

Fixing wrong Python identifier used for SMOOTH_ALL.
Expose all UV interpolation modes.

The default one is now UVs are smoothed, boundaries are kept sharp.

This fixes distortion reported in T83470.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) created this revision.Jan 14 2021, 4:07 PM

Harbormaster completed remote builds in B12189: Diff 32777.Jan 14 2021, 4:07 PM

Attempt to bring missed commits to the review.

Harbormaster completed remote builds in B12190: Diff 32778.Jan 14 2021, 4:09 PM

Brecht Van Lommel (brecht) accepted this revision.Jan 14 2021, 4:11 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/makesrna/intern/rna_modifier.c
1665 ↗	(On Diff #32778)	boundaries -> Boundaries

This revision is now accepted and ready to land.Jan 14 2021, 4:11 PM

Switch default to PRESERVE_BOUNDARIES.

This is something we have discussed with Brecht here are the studio.
Updating the patch, so that there is no discrepancy between of what
was accepted in the past and what came out of followup discussion.

One thing is that modifiers test is now failing. Need to address
this, but first need to understand what is it exactly test should
consider a regression.

Harbormaster completed remote builds in B12266: Diff 32898.Jan 19 2021, 10:06 AM

Sergey Sharybin (sergey) edited the summary of this revision. (Show Details)Jan 19 2021, 10:07 AM

Eugene Du (APEC) mentioned this in T83470: There is no difference between "keep corners" and "all" under "UV Smooth".Jan 22 2021, 3:28 PM

Closed by commit rB3d3b6d94e6e6: Subdiv: Use better default UV interpolation (authored by Sergey Sharybin (sergey)). · Explain WhyJan 26 2021, 4:23 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB3d3b6d94e6e6: Subdiv: Use better default UV interpolation.

Just for the record. The default did change compared to the state of the code at which Brecht accepted the revision. This is something we've discussed here at the studio.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

2 lines

makesdna/

DNA_modifier_defaults.h

4 lines

render/

intern/

multires_bake.c

2 lines

Diff 33157

source/blender/blenkernel/intern/multires.c

Loading...

source/blender/makesdna/DNA_modifier_defaults.h

Loading...

source/blender/render/intern/multires_bake.c

Loading...