Fix T84512: Crash if size input of Blur node is too large
ClosedPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Jan 15 2021, 6:57 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Sergey Sharybin (sergey)

Maniphest Tasks

T84512: Crash - Compositor. Depth pass in the "size" input socket of "Blur" node. Only Cycles.

Commits

rB51c8d53a7d0e: Fix T84512: Crash if size input of Blur node is too large

Summary

Gaussian filter with a too large kernel doesn't make much sense. This commit caps the Gaussian function radius to MAX_GAUSSTAB_RADIUS. I will add a test case once D6334 is accepted.

Diff Detail

Repository: rB Blender

Event Timeline

Habib Gahbiche (zazizizou) requested review of this revision.Jan 15 2021, 6:57 PM

Habib Gahbiche (zazizizou) created this revision.

Harbormaster completed remote builds in B12212: Diff 32820.Jan 15 2021, 6:57 PM

Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)Jan 15 2021, 6:59 PM

Habib Gahbiche (zazizizou) added a reviewer: Jeroen Bakker (jbakker).

Habib Gahbiche (zazizizou) added a task: T84512: Crash - Compositor. Depth pass in the "size" input socket of "Blur" node. Only Cycles..Jan 15 2021, 7:02 PM

Think this is fine.

This revision is now accepted and ready to land.Jan 26 2021, 12:37 PM

Thanks for reviewing @Sergey Sharybin (sergey). Could you commit the patch? I have no commit access.

Closed by commit rB51c8d53a7d0e: Fix T84512: Crash if size input of Blur node is too large (authored by Habib Gahbiche (zazizizou), committed by Sergey Sharybin (sergey)). · Explain WhyJan 28 2021, 10:54 AM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB51c8d53a7d0e: Fix T84512: Crash if size input of Blur node is too large.

Revision Contents
Changeset List

Path

Size

source/

blender/

compositor/

operations/

COM_GaussianAlphaXBlurOperation.cpp

1 line

COM_GaussianAlphaYBlurOperation.cpp

1 line

COM_GaussianXBlurOperation.cpp

1 line

COM_GaussianYBlurOperation.cpp

1 line

Diff 33236

View Options

source/blender/compositor/operations/COM_GaussianAlphaXBlurOperation.cpp

View Options

source/blender/compositor/operations/COM_GaussianAlphaYBlurOperation.cpp

View Options

source/blender/compositor/operations/COM_GaussianXBlurOperation.cpp

View Options

source/blender/compositor/operations/COM_GaussianYBlurOperation.cpp

Fix T84512: Crash if size input of Blur node is too largeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33236

source/blender/compositor/operations/COM_GaussianAlphaXBlurOperation.cpp

source/blender/compositor/operations/COM_GaussianAlphaYBlurOperation.cpp

source/blender/compositor/operations/COM_GaussianXBlurOperation.cpp

source/blender/compositor/operations/COM_GaussianYBlurOperation.cpp

Fix T84512: Crash if size input of Blur node is too large
ClosedPublic
Actions

Revision Contents
Changeset List