Page MenuHome
Differential D10123

Fix T84713: Implement the update function for geometry nodes
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Jan 15 2021, 7:03 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T84713: Reroute Colors, behave differently in Geomtry Nodes compared to Shader Nodes or Compositor Nodes
Commits
rB6fb7d0f55927: Fix T84713: Geometry nodes reroute sockets have incorrect type
Summary

This is needed so that the reroutes get updated to the correct type.
Based on the same code in the shader and compositor node trees.

Before:

After:

Diff Detail

Repository
rB Blender
Branch
reroute (branched from master)
Build Status
Buildable 12217
Build 12217: arc lint + arc unit

Event Timeline

Wannes Malfait (Wannes) created this revision.Jan 15 2021, 7:03 PM
Harbormaster completed remote builds in B12213: Diff 32821.Jan 15 2021, 7:03 PM
Wannes Malfait (Wannes) requested review of this revision.Jan 15 2021, 7:03 PM
Wannes Malfait (Wannes) retitled this revision from Implement the update function for geometry nodes (Fixes: T84713). This is needed so that the reroutes get updated to the correct type. Based on the same code in the shader and compositor node trees. to Implement the update function for geometry nodes (fixes T84713).Jan 15 2021, 7:04 PM
Wannes Malfait (Wannes) edited the summary of this revision. (Show Details)
Wannes Malfait (Wannes) added a project: Geometry Nodes.
Wannes Malfait (Wannes) retitled this revision from Implement the update function for geometry nodes (fixes T84713) to Fix T84713: Implement the update function for geometry nodes .
Wannes Malfait (Wannes) added a task: T84713: Reroute Colors, behave differently in Geomtry Nodes compared to Shader Nodes or Compositor Nodes.Jan 15 2021, 7:16 PM
Wannes Malfait (Wannes) edited the summary of this revision. (Show Details)Jan 15 2021, 7:21 PM
Hans Goudey (HooglyBoogly) requested changes to this revision.Jan 15 2021, 8:25 PM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).

Thanks for the patch! Looks good to me, just a few little tweaks.

source/blender/nodes/geometry/node_geometry_tree.cc
27

Usually local includes go at the bottom of the list, so below "RNA_access.h"

68

geometry_node_tree_update would be more consistent with the other name in this file.

This revision now requires changes to proceed.Jan 15 2021, 8:25 PM
Wannes Malfait (Wannes) updated this revision to Diff 32826.Jan 16 2021, 9:12 AM
Wannes Malfait (Wannes) retitled this revision from Fix T84713: Implement the update function for geometry nodes to Fix T84713: Implement the update function for geometry nodes.

Rename function and reorder import for consistency with the rest of the file.

Harbormaster completed remote builds in B12217: Diff 32826.Jan 16 2021, 9:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2021, 8:11 PM
Closed by commit rB6fb7d0f55927: Fix T84713: Geometry nodes reroute sockets have incorrect type (authored by Wannes Malfait (Wannes), committed by Hans Goudey (HooglyBoogly)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB6fb7d0f55927: Fix T84713: Geometry nodes reroute sockets have incorrect type.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
9 lines

Diff 32826

View Options

source/blender/nodes/geometry/node_geometry_tree.cc

Loading...