Fix T84600: prevent bone groups operators on proxies/overrides
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 17 2021, 5:45 PM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T84600: Blender Bone Groups Assigning for linked blender file

Commits

rB1c2b2037956b: Fix T84600: prevent bone groups operators on proxies and library

Summary

Editing bone groups is not supported on proxies/overrides [changes a re
lost on file reload], need to do proper polling (and also prevent this
from rna) for:

adding bone groups
removing bone groups
renaming bone groups
setting bone groups colors

Previously, this was hinted at by setting the layout inactive, with
preoper polls, this is now not needed anymore.

note: Selection of bone groups actually makes sense here and is
supported, so this is not prevented in this patch, but UI wise this is
not nice because one cannot set an active_index (aka select) in the UI
list.

Diff Detail

Repository

rB Blender

Branch

T84600 (branched from master)

Build Status

Buildable 12236
Build 12236: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 17 2021, 5:45 PM

Harbormaster completed remote builds in B12236: Diff 32849.Jan 17 2021, 5:45 PM

Philipp Oeser (lichtwerk) requested review of this revision.Jan 17 2021, 5:45 PM

Philipp Oeser (lichtwerk) added projects: User Interface, Animation & Rigging, Pipeline, Assets & I/O.Jan 17 2021, 5:46 PM

Looks fine mostly, just details in notes below.

source/blender/editors/armature/pose_group.c
65	space ;)
66	proxies or library overrides
source/blender/makesrna/intern/rna_pose.c
144	No need to check for NULL `reports` I think? Iirc `BKE_report` API deals properly with them, and just prints to console then.