Page MenuHome

Fix T84824: Incorrect height using interactive add tool
ClosedPublic

Authored by Falk David (filedescriptor) on Jan 18 2021, 11:11 PM.

Details

Summary

When using the interactive add tool for primitives with a fixed
height and base aspect ratio, the height of the created primitive
would be incorrect (two times too small or two times too big).

When the base origin was centered, the fixed_aspect_dimension
was not changed even though the base length was doubled.
Additionally, when the height origin was centered but the height
aspect ration was fixed, the height was doubled leading to an
incorrect size.

The fix doubles fixed_aspect_dimension when the base origin is
centered and correctly calculates the height of the primitive when
the aspect ration is set to fixed.

Diff Detail

Repository
rB Blender
Branch
T84824 (branched from master)
Build Status
Buildable 12256
Build 12256: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Jan 18 2021, 11:11 PM
Falk David (filedescriptor) retitled this revision from Fix T84824: Incorrect height interactive add tool to Fix T84824: Incorrect height using interactive add tool.
This revision is now accepted and ready to land.Jan 19 2021, 3:23 AM