Page MenuHome
Differential D10147

Geometry Nodes: Initial support for volumes.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 19 2021, 3:27 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T84604: Support volume objects in the geometry node tree for moss use case
Commits
rB793547e7d140: Geometry Nodes: initial support for volumes
Summary

For the most part, this just adds boilerplate code for volume support in geometry nodes:

  • Add VolumeComponent next to MeshComponent, etc.
  • Support VolumeComponent in depsgraph object iterator.

Furthermore, I added initial volume support in a few nodes:

  • The Object Info nodes outputs an Object Instance when the input is a volume object (that will be the same for mesh objects soonish, to avoid copies).
  • Support transforming a VolumeComponent in the Transform node.
  • Support the VolumeComponent in Join Geometry nodes, but only when just one of the inputs has a volume component for now.

Right now there is no way to create a VolumeComponent, because the Object Info node outputs a Volume Object Instance. The VolumeComponent will be necessary for nodes like T84606: Points to Volume modifier for the moss use case. I tested the VolumeComponent code by outputting a copy of the volume from the Object Info node, but didn't want to commit that to master.

Viewport selection does not work correctly with VolumeComponents currently. I don't know why that is. That can be figured out a bit later, once we can actually create new volumes in geometry nodes.

Ref T84604.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 19 2021, 3:27 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B12272: Diff 32912.Jan 19 2021, 3:27 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 19 2021, 3:31 PM
Jacques Lucke (JacquesLucke) added a project: Geometry Nodes.
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added a task: T84604: Support volume objects in the geometry node tree for moss use case.
Jacques Lucke (JacquesLucke) updated this revision to Diff 32914.Jan 19 2021, 3:36 PM
  • support building without openvdb
  • Add todo
Harbormaster completed remote builds in B12274: Diff 32914.Jan 19 2021, 3:36 PM
Jacques Lucke (JacquesLucke) mentioned this in D10150: Volumes: Fix calling BKE_volume_load from multiple threads..Jan 19 2021, 5:52 PM
Jacques Lucke (JacquesLucke) updated this revision to Diff 32957.Jan 20 2021, 11:52 AM
  • Merge branch 'master' into temp-geometry-nodes-volume
Harbormaster completed remote builds in B12292: Diff 32957.Jan 20 2021, 11:52 AM
Jacques Lucke (JacquesLucke) updated this revision to Diff 32962.Jan 20 2021, 1:34 PM

o - output instance in object info node

Harbormaster completed remote builds in B12297: Diff 32962.Jan 20 2021, 1:34 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 20 2021, 1:39 PM
Jacques Lucke (JacquesLucke) retitled this revision from Geometry Nodes: Initial support for volume components in geometry set. to Geometry Nodes: Initial support for volumes..Jan 20 2021, 1:54 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added reviewers: Brecht Van Lommel (brecht), Hans Goudey (HooglyBoogly).Jan 20 2021, 1:56 PM
Brecht Van Lommel (brecht) awarded a token.Jan 20 2021, 2:00 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jan 20 2021, 5:16 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/nodes/CMakeLists.txt
370–372

This is not needed, the volume object does not use our C API for OpenVDB.

377

Same, this can also be left out.

source/blender/nodes/geometry/nodes/node_geo_transform.cc
134

I was not aware of this limitation, where exactly does this go wrong?

159

Add missing params and put under an #else.

This revision now requires changes to proceed.Jan 20 2021, 5:16 PM
Jacques Lucke (JacquesLucke) updated this revision to Diff 32969.Jan 20 2021, 7:40 PM
  • remove unnecessary cmake code
  • fix unused var
  • Merge branch 'master' into temp-geometry-nodes-volume
  • fix scale check

Only scaling an axis to zero is not supported actually.
Negative scales are currently not drawn in the viewport, I assume this is a bug in drawing code.
I updated the check to only disallow zero.

Harbormaster completed remote builds in B12301: Diff 32969.Jan 20 2021, 7:40 PM
Brecht Van Lommel (brecht) accepted this revision.Jan 20 2021, 8:03 PM
This revision is now accepted and ready to land.Jan 20 2021, 8:03 PM
Closed by commit rB793547e7d140: Geometry Nodes: initial support for volumes (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 21 2021, 10:38 AM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB793547e7d140: Geometry Nodes: initial support for volumes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
27 lines
intern/
103 lines
2 lines
depsgraph/
intern/
24 lines
nodes/
7 lines
geometry/
nodes/
9 lines
11 lines
50 lines

Diff 32984

View Options

source/blender/blenkernel/BKE_geometry_set.hh

Loading...
View Options

source/blender/blenkernel/intern/geometry_set.cc

Loading...
View Options

source/blender/blenkernel/intern/volume.cc

Loading...
View Options

source/blender/depsgraph/intern/depsgraph_query_iter.cc

Loading...
View Options

source/blender/nodes/CMakeLists.txt

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_object_info.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_transform.cc

Loading...