Volumes: Fix calling BKE_volume_load from multiple threads.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 19 2021, 5:48 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB05179a0ba489: Volumes: fix calling BKE_volume_load from multiple threads

Summary

BKE_volume_is_loaded uses grids.filepath to determine if the grids are already loaded. The issue was that grids.filepath was set, before the grids were loaded, resulting in incorrect early returns for other threads.

Noticed that while working on D10147.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 19 2021, 5:48 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B12279: Diff 32925.Jan 19 2021, 5:48 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jan 19 2021, 5:52 PM

Brecht Van Lommel (brecht) accepted this revision.Jan 19 2021, 5:53 PM

This revision is now accepted and ready to land.Jan 19 2021, 5:53 PM

That was fast, didn't even add you as a reviewer yet :D

Closed by commit rB05179a0ba489: Volumes: fix calling BKE_volume_load from multiple threads (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 19 2021, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB05179a0ba489: Volumes: fix calling BKE_volume_load from multiple threads.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

volume.cc

15 lines

Diff 32932

View Options

source/blender/blenkernel/intern/volume.cc

Volumes: Fix calling BKE_volume_load from multiple threads.ClosedPublicActions