VSE: Make added Transform strip inherit blend-mode from the assigned strip.
ClosedPublic
Actions

Authored by Peter Fog (tintwotin) on Jan 20 2021, 7:22 AM.

Details

Reviewers

Commits

rBd6bbcc4f666b: VSE: Inherit blend mode with single input effects

Summary

As suggested in this RCS request https://blender.community/c/rightclickselect/HVgbbc by @Corwin Kerr (ckerr), making added Transform strip inherit blend-mode from the assigned strip, will improve the "it should just work" experience, since it then would not change the rendering of the underlying strips.

Current problematic behaviour:

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Jan 20 2021, 7:22 AM

Peter Fog (tintwotin) created this revision.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Jan 20 2021, 3:04 PM

Peter Fog (tintwotin) added a subscriber: Corwin Kerr (ckerr).

Corwin Kerr (ckerr) awarded a token.Jan 20 2021, 5:07 PM

Thanks for patch, Perhaps we should do this for all effect strips that do have 1 input? Seems reasonable and more useful to me.

else if (SEQ_effect_get_num_inputs(seq->type) == 1) {
  seq->blend_mode = seq1->blend_mode;
}

2 input effects could do this as well by some introspection, but I am not sure we can guess intention here really.

Perhaps we should do this for all effect strips that do have 1 input

I agree. In my gif for the RCS post ("VSE: Blend mode of new effect strip should inherit from input strip by default"), I just chose the Transform effect for illustration.

Patch updated with the suggested changes.

Richard Antalik (ISS) accepted this revision.Jan 22 2021, 3:08 AM

This revision is now accepted and ready to land.Jan 22 2021, 3:08 AM

Closed by commit rBd6bbcc4f666b: VSE: Inherit blend mode with single input effects (authored by Peter Fog (tintwotin), committed by Richard Antalik (ISS)). · Explain WhyJan 25 2021, 5:49 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBd6bbcc4f666b: VSE: Inherit blend mode with single input effects.