Differential D10158

Fix T76936: Mesh shape amended upon undoing in sculpt mode
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jan 20 2021, 12:16 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)
Pablo Dobarro (pablodp606)
Philipp Oeser (lichtwerk)

Maniphest Tasks

T76936: Mesh shape amended upon undoing in sculpt mode, with Armature & Multires modifiers enabled

Commits

rB2ba2d2bd9ded: Fix T76936: Mesh shape amended upon undoing in sculpt mode

Summary

Was happening when there are deform modifiers prior to the multires.

There are detail in the comment around sculpt_undo_refine_subdiv(),
but briefly: the subdiv was refined with wrong base mesh coordinates.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) created this revision.Jan 20 2021, 12:16 PM

Harbormaster completed remote builds in B12293: Diff 32958.Jan 20 2021, 12:16 PM

Sergey Sharybin (sergey) requested review of this revision.Jan 20 2021, 12:16 PM

Sergey Sharybin (sergey) added a task: T76936: Mesh shape amended upon undoing in sculpt mode, with Armature & Multires modifiers enabled.Jan 20 2021, 12:16 PM

Brecht Van Lommel (brecht) accepted this revision.Jan 20 2021, 12:53 PM

This revision is now accepted and ready to land.Jan 20 2021, 12:53 PM

Can confirm it is working fine now.

Pablo Dobarro (pablodp606) accepted this revision.Jan 21 2021, 11:21 PM

Closed by commit rB2ba2d2bd9ded: Fix T76936: Mesh shape amended upon undoing in sculpt mode (authored by Sergey Sharybin (sergey)). · Explain WhyJan 22 2021, 12:26 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB2ba2d2bd9ded: Fix T76936: Mesh shape amended upon undoing in sculpt mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

34 lines

Diff 33025

source/blender/editors/sculpt_paint/sculpt_undo.c

Loading...