Page MenuHome

Fix T84896: Boundary brush not affected by automasking
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Jan 20 2021, 9:09 PM.

Details

Summary

This uses the values form the stroke automasking cache to control the
falloff of all deformers in the boundary brush. Usually this is already
considered in the general brush falloff function for the rest of the
brushes, but this is one of the exceptions where the brush implements
its custom falloff.

Diff Detail

Repository
rB Blender
Branch
T84896 (branched from master)
Build Status
Buildable 12302
Build 12302: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jan 20 2021, 9:09 PM
Pablo Dobarro (pablodp606) created this revision.

The changes make sense to me and do fix the bug.

Testing this I noticed that there is a memory leak when using the boundary brush. It's not related to this patch though.

Error: Not freed memory blocks: 16, total unfreed memory 0.031681 MB
boundary edges len: 2400 0x61e0002850b8
boundary edges len: 2400 0x61e0002880b8
boundary edges len: 2400 0x61e00028c8b8
boundary edges len: 2400 0x61e00028e0b8
boundary edges len: 2400 0x61e00028f8b8
boundary edges len: 2400 0x61e0002910b8
boundary edges len: 2400 0x61e0002928b8
boundary edges len: 2400 0x61e0002940b8
boundary edges len: 2400 0x61e0002958b8
boundary edges len: 2400 0x61e0002970b8
boundary edges len: 2400 0x61e0002a6cb8
boundary edges len: 2400 0x61e0002ad8b8
Boundary edit data len: 136 0x6110001a96b8
boundary indices len: 1200 0x61a000011ab8
boundary edges len: 2400 0x61e0002af0b8
Boundary edit info len: 684 0x617000040cb8
This revision is now accepted and ready to land.Jan 21 2021, 10:28 AM