Page MenuHome

Cycles standalone new api udpate
AbandonedPublic

Authored by Piotr Barejko (bareya) on Jan 20 2021, 9:49 PM.

Details

Reviewers
Kévin Dietrich (kevindietrich)
Group Reviewers
Cycles
Summary

It seems like standalone Cycles has not been updated, therefore it does not compile.

What I am not sure in this PR is:

  • cam->need_update = true; has been removed.
  • cam->width <-> cam->get_full_width.

Diff Detail

Repository
rC Cycles

Event Timeline

Piotr Barejko (bareya) requested review of this revision.Jan 20 2021, 9:49 PM
Piotr Barejko (bareya) created this revision.
Piotr Barejko (bareya) edited the summary of this revision. (Show Details)

Thanks for the patch, however another one to fix compilation of Cycles standalone due to API breakage is already in code review (D9961), which will be dealt with promptly. I will add you subscriber there, so you get notified when it is merged.

For future reference, about your uncertainty:

cam->need_update = true can be replaced with cam->tag_modified() if the intent is to force an update. With the new socket API, Cycles will automatically detect changes, and manually tagging for an update is not needed anymore in most cases.

cam->width is now for internal use, so Camera.get_full_width or BufferParams.width can be used instead.