Fix T84661: read jpg pixel density
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 21 2021, 4:22 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T84661: Can't read metadata data (EXIF) information in JPEG files

Commits

rB6f88053d852a: Fix T84661: read jpg pixel density

Summary

For jpeg, an image.resolution was always based on the default 72dpi, now
read the pixel density from the jpeg_decompress_struct, convert
according to unit and store in IMBuf's ppm.

Not 100% sure of all implications tbh., files I have checked seem to work
as expected now in the context of the report.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jan 21 2021, 4:22 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B12309: Diff 32994.Jan 21 2021, 4:22 PM

Not sure who can review this?

CC @Sergey Sharybin (sergey)
CC @Campbell Barton (campbellbarton)

Philipp Oeser (lichtwerk) mentioned this in T84661: Can't read metadata data (EXIF) information in JPEG files.Jan 21 2021, 4:25 PM

I think this is fine.
Annoyingly, that it seems to be no mnemonic names for the jpeg's density_unit, but we have what we have. Maybe consider defining them as an enum on our side.

This revision is now accepted and ready to land.Jan 29 2021, 9:43 AM

Closed by commit rB6f88053d852a: Fix T84661: read jpg pixel density (authored by Philipp Oeser (lichtwerk)). · Explain WhyJan 29 2021, 11:37 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB6f88053d852a: Fix T84661: read jpg pixel density.