Details

Reviewers

Commits

rBAd47e9be4fb20: Fix: replaced Python module "imp" with "implib"

Summary

Python 3.4.0 deprecated the "imp" module, and replaced it with
"importlib". This changes imp.reload() into implib.reload().

Diff Detail

Repository: rBA Blender Add-ons
Branch: temp-sybren-replace-imp-module

Event Timeline

Sybren A. Stüvel (sybren) updated this revision to Diff 3220.Jan 21 2015, 8:08 PM

Sybren A. Stüvel (sybren) retitled this revision from to Fix: replaced Python module "imp" with "implib".

Sybren A. Stüvel (sybren) updated this object.

Updated diff

Git updated origin/master but not master, so some changes on master branch ended up here.

Sybren A. Stüvel (sybren) added a reviewer: Campbell Barton (campbellbarton).Jan 21 2015, 9:03 PM

The io_import_dxf addon uses imp.load_dynamic(), which no longer exists in the new importlib module. This is *not* fixed in this patch, as it requires more than trivial changes. It also depends on a file cytags.so that isn't shipped with Blender, so I wouldn't be able to test it without more info.

The simple replacement for imp.reload seem fine, but theres some issue with render_renderfarmfi addon that should be resolved before committing.

(or just revert those changes and resolve later, along with the other non-trivial imp issues).

render_renderfarmfi/rpc.py
34 ↗	(On Diff #3223)	implib doesn't exist, and seems `importlib.load_module` doesnt exist either.

This revision now requires changes to proceed.Jan 22 2015, 7:11 AM

Removed non-trivial change; now really the only thing changing is imp.reload() to importlib.reload()

Campbell Barton (campbellbarton) accepted this revision.Jan 23 2015, 12:28 AM

Campbell Barton (campbellbarton) edited edge metadata.

This revision is now accepted and ready to land.Jan 23 2015, 12:28 AM

Closed by commit rBAd47e9be4fb20: Fix: replaced Python module "imp" with "implib" (authored by Sybren A. Stüvel (sybren), committed by Campbell Barton (campbellbarton)). · Explain WhyJan 23 2015, 4:42 AM

This revision was automatically updated to reflect the committed changes.

Fix: replaced Python module "imp" with "implib"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3234

add_curve_extra_objects/__init__.py

add_curve_sapling/__init__.py

add_mesh_BoltFactory/__init__.py

add_mesh_extra_objects/__init__.py

io_anim_bvh/__init__.py

io_anim_nuke_chan/__init__.py

io_coat3D/__init__.py

io_convert_image_to_mesh_img/__init__.py

io_curve_svg/__init__.py

io_mesh_ply/__init__.py

io_mesh_raw/__init__.py

io_mesh_stl/__init__.py

io_mesh_uv_layout/__init__.py

io_scene_3ds/__init__.py

io_scene_ms3d/__init__.py

io_scene_obj/__init__.py

io_scene_vrml2/__init__.py

io_scene_x3d/__init__.py

io_shape_mdd/__init__.py

light_field_tools/__init__.py

mesh_inset/__init__.py

mocap/__init__.py

netrender/__init__.py

object_fracture/__init__.py

object_fracture_cell/__init__.py

object_print3d_utils/__init__.py

render_copy_settings/__init__.py

render_povray/__init__.py

rigify/__init__.py

rigify/rigs/biped/arm/__init__.py

rigify/rigs/biped/leg/__init__.py

rigify/rigs/pitchipoy/super_widgets.py

rigify/ui.py

rigify/utils.py

space_view3d_math_vis/__init__.py

system_demo_mode/__init__.py

ui_translate/__init__.py

ui_translate/edit_translation.py

ui_translate/settings.py

ui_translate/update_addon.py

ui_translate/update_svn.py

ui_translate/update_ui.py

Fix: replaced Python module "imp" with "implib"
ClosedPublic
Actions

Revision Contents
Changeset List

add_curve_extra_objects/init.py

add_curve_sapling/init.py

add_mesh_BoltFactory/init.py

add_mesh_extra_objects/init.py

io_anim_bvh/init.py

io_anim_nuke_chan/init.py

io_coat3D/init.py

io_convert_image_to_mesh_img/init.py

io_curve_svg/init.py

io_mesh_ply/init.py

io_mesh_raw/init.py

io_mesh_stl/init.py

io_mesh_uv_layout/init.py

io_scene_3ds/init.py

io_scene_ms3d/init.py

io_scene_obj/init.py

io_scene_vrml2/init.py

io_scene_x3d/init.py

io_shape_mdd/init.py

light_field_tools/init.py

mesh_inset/init.py

mocap/init.py

netrender/init.py

object_fracture/init.py

object_fracture_cell/init.py

object_print3d_utils/init.py

render_copy_settings/init.py

render_povray/init.py

rigify/init.py

rigify/rigs/biped/arm/init.py

rigify/rigs/biped/leg/init.py

space_view3d_math_vis/init.py

system_demo_mode/init.py

ui_translate/init.py