Differential D10174

Fix T84370: Project tool not working with shape keys
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Jan 22 2021, 12:31 AM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T84370: Sculpt: Line Project doesn't work with Shape Keys

Commits

rB1081eee4c569: Fix T84370: Project tool not working with shape keys

Summary

A missing flush of the deformed PBVH coordinates to the shape key.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Jan 22 2021, 12:31 AM

Harbormaster completed remote builds in B12316: Diff 33013.Jan 22 2021, 12:31 AM

Pablo Dobarro (pablodp606) requested review of this revision.Jan 22 2021, 12:31 AM

Pablo Dobarro (pablodp606) added a reviewer: Jacques Lucke (JacquesLucke).Jan 25 2021, 10:05 PM

I don't really understand all the implications of what is happening here, but it seems to make sense and fixes the issue. Similar code can be found in a couple other places.

source/blender/editors/sculpt_paint/paint_mask.c
1468	remove newline

This revision is now accepted and ready to land.Jan 27 2021, 2:02 PM

Closed by commit rB1081eee4c569: Fix T84370: Project tool not working with shape keys (authored by Pablo Dobarro (pablodp606)). · Explain WhyFeb 3 2021, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) marked an inline comment as done.

Pablo Dobarro (pablodp606) added a commit: rB1081eee4c569: Fix T84370: Project tool not working with shape keys.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

paint_mask.c

6 lines

Diff 33504

View Options

source/blender/editors/sculpt_paint/paint_mask.c

Fix T84370: Project tool not working with shape keysClosedPublicActions