Details

Reviewers

Commits

rB8f707a72e818: UI: Multi-input node socket spacing and interaction

Summary

This patch is based on D10067

Makes links connected to Multi Input Sockets verticaly spread along the socket.
Sockets are growing if more links are connected and Node layout updates accordingly.
Linkes are sorted by angle between fromlink to tolink to avoid crossing links.
link picking is updated to work with spread links and bezier links.

Overview of changes:

Adds support for multiple links that are connected to one socket to be drawn with a small gap between
Adds support for multiple links that are connected to one socket to be sorted by Y position of the from_node
Adds support for links from Multi Input Sockets being picked by a dragging gesture
Adds support for links being highlighted while being picked by a dragging gesture

source/blender/editors/space_node/node_relationships.c
source/blender/editors/space_node/drawnode.

Adds support for node layout changes according to dynamic socket height of Multi Input Sockets.

source/blender/editors/interface/interface_widgets.c

Changes socket drawing from GL_POINTS to GL_TRIANGLES (using new shader)to display long rectangle shape which is not possible with GL_POINTS
Changes the way the node layout is calculated to work with growing Multi Input Sockets
Adds a constant for highlight color for links that are being highlighted while being picked by dragging gesture.
Adds support for links with the flag NODE_LINK_HIGHLIGHT to be drawn with the highlight color.

source/blender/editors/space_node/node_draw.c

Adds support for mouse cursor can interact with non square sockets in node_find_indicated_socket()
Adds the function node_socket_calculate_height() to calculate socket height.

source/blender/editors/space_node/node_edit.c

Adds define for gap between linkes that are connected to Multi Input Sockets NODE_MULTI_INPUT_LINK_GAP */

source/blender/editors/space_node/node_intern.h

Adds a new shape flag SOCK_DISPLAY_SHAPE_MULTI
Adds a member to bNodeSocket to store total input linkes
Adds a member to bNodeLink to store its index on Multi Input Sockets
Adds a define for the flag NODE_LINK_HIGHLIGHT that is used to store that a link is highlighted on picking gesture*/

source/blender/makesdna/DNA_node_types.h

source/blender/nodes/intern/node_util.c

Make Multi Input Sockets use the new shape id

source/blender/nodes/intern/node_socket.cc

Adds a new shader that is used instead of gpu_shader_keyframe_diamond
and is capable of drawing the new shape in different heights.

source/blender/gpu/CMakeLists.txt
source/blender/gpu/GPU_shader.h
source/blender/gpu/intern/gpu_shader_builtin.c
source/blender/gpu/shaders/gpu_shader_node_socket_frag.glsl
source/blender/gpu/shaders/gpu_shader_node_socket_vert.glsl

Changes that are needed because signiture of node_draw_socket changes

source/blender/editors/include/ED_node.h

Diff Detail

Repository

rB Blender

Branch

geometry_nodes_multi_input_socket_new_drawing (branched from master)

Build Status

Buildable 12676
Build 12676: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Fabian Schempp (fabian_schempp) edited the summary of this revision. (Show Details)Feb 1 2021, 11:49 PM

Hans Goudey (HooglyBoogly) retitled this revision from Geometry Nodes: Socket Growing and Link Spaceing to UI: Multi-input node socket spacing and interaction.Feb 2 2021, 1:39 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) added projects: User Interface, Nodes & Physics.

Hans Goudey (HooglyBoogly) added inline comments.Feb 2 2021, 2:22 AM

source/blender/editors/space_node/node_draw.c
539	Same comment as somewhere else. It's tempting to do this, but these sort of cleanups should be in a separate commit / patch.
722–738	Why are you deleting all this?
source/blender/editors/space_node/node_edit.c
1156–1162	This can be written a bit more nicely: const rctf multi_socket_rect = { .xmin = sock->locx - NODE_SOCKSIZE * 4, .xmax = sock->locx + NODE_SOCKSIZE, .ymin = sock->locy - node_socket_calculate_height(sock) * 0.5 - NODE_SOCKSIZE * 2.0f, .ymax = sock->locy + node_socket_calculate_height(sock) * 0.5 + NODE_SOCKSIZE * 2.0f, }; I also suggest splitting this bit of logic to a separate function named something like: `static bool cursor_isect_multi_input_socket()`
source/blender/editors/space_node/node_relationships.c
40	`<>` -> `""`
280	The `MUTABLE` loops are for when listbase links are removed or freed while iterating. Since this loop doesn't do that, it doesn't need the `MUTABLE` suffix.
source/blender/makesdna/DNA_node_types.h
176	The other socket display shapes are exposed to RNA in `rna_enum_node_socket_display_shape_items`. I'm fine leaving out exposing the new socket shape and drawing from the RNA API for now since this patch set is already pretty large, but it should probably be noted there that this is left out for now.

Hans Goudey (HooglyBoogly) added inline comments.Feb 2 2021, 4:24 AM

source/blender/editors/space_node/node_draw.c
762	I would think using the existing `UI_draw_roundbox_4fv_ex` would be preferable to this.

Florian Kamenz (TimBrown) awarded a token.Feb 2 2021, 1:33 PM

Changes based on Review by Hans Goudey.

Harbormaster completed remote builds in B12560: Diff 33460.Feb 2 2021, 10:02 PM

The overall experience is super nice! I've got two comments:

Noodle Color

The hard-coded red-ish tint when unplugging a noodle doesn't feel right. alghough I can't think of an ideal solution right now.

White (theme for "active"): Won't work when the node is active, since all noodles connected to it become white too.
Orange (theme for "selected"): In Blender it currently means selected. Not wrong but not right either.
Red (theme for "alert"): Makes it look like an error (in the near future noodles with errors will become red)

Since soon we are going to have colored wires (based on the socket they come from/connect to) anyway, for the time being I'd just go with orange or theme for "Node Selected".

Expand/contract Behavior

The current "delay" on resizing the socket when a wire is plugged/unplugged, makes it feel not so responsive.

This could be solved by adjusting the size of the socket as soon as the noodle snaps, before releasing/executing the connection. This would solve another issue that happens when the noodle snaps to the same place where there is another noodle currently, suggesting it will replace it (instead of being added below it).

One problem this would introduce though is that we lose that feeling of "ah the node has been executed", but this could be communicated differently (in the compositor for example the node outline is highlighted).

So my suggestions would be to changing the color of the selected wire and resizing the socket on snap, not on release.

Hans Goudey (HooglyBoogly) mentioned this in rBc5514d3a2a03: Geometry Nodes: Multi-Input Sockets.Feb 3 2021, 6:03 PM

Fabian Schempp (fabian_schempp) mentioned this in D10080: Nodes: Make Virtual Sockets better recognizable..Feb 3 2021, 8:25 PM

Changed link preselection highlighting color to use Theme Selected Color (Orange) based on Review by Pablo Vazquez.

Harbormaster completed remote builds in B12591: Diff 33516.Feb 3 2021, 11:49 PM

Changed treshhold in shader to make edge a bit more smooth, based on Review by Pablo Vazquez.

Harbormaster completed remote builds in B12592: Diff 33517.Feb 4 2021, 12:05 AM

@Pablo Vazquez (pablovazquez) Based on your comment in D10080 I changed the new shader to draw the edges of the sockets a bit less crisp. But it's very hard to tell on my monitor if it's really better now. Would be awesome if you could take a look again.

Applyed ClangFormat.

Harbormaster completed remote builds in B12595: Diff 33520.Feb 4 2021, 12:49 AM

Fixed memoryleak by using BLI_freelinkN instad of BLI_remlink.

Harbormaster completed remote builds in B12628: Diff 33566.Feb 4 2021, 5:26 PM

Drag Link update Socket and Node layout on snapping.

Harbormaster completed remote builds in B12639: Diff 33579.Feb 4 2021, 9:58 PM

@Pablo Vazquez (pablovazquez) I made sockets and node update on drag snapping, as you suggested.
That means, that both of your requested changes have been implemented.

---> ATTENTION: I removed the new shader. So you don't have to look into this.

Removed unneeded changes.

Harbormaster completed remote builds in B12642: Diff 33585.Feb 5 2021, 8:52 AM

Multi Input Sockets now are drawn using UI_draw_roundbox instead of an special shader.

Harbormaster completed remote builds in B12644: Diff 33588.Feb 5 2021, 12:09 PM

Fabian Schempp (fabian_schempp) marked 2 inline comments as done.Feb 5 2021, 12:15 PM

Charlie Jolly (charlie) added a subscriber: Charlie Jolly (charlie).Feb 5 2021, 12:43 PM

Charlie Jolly (charlie) added inline comments.

source/blender/makesdna/DNA_node_types.h
176	Minor comment but MULTI isn't a display shape. I don't think `SOCK_DISPLAY_SHAPE_MULTI` is needed and just document that changing the shape is not supported for MULTI sockets. In future, a MULTI socket may have square or diamond shape for example.

Removed SOCK_DISPLAY_SHAPE_MULTI form shapes enum, based on comment form Charlie Jolly.

Harbormaster completed remote builds in B12676: Diff 33647.Feb 5 2021, 9:18 PM

Fabian Schempp (fabian_schempp) marked 2 inline comments as done.Feb 5 2021, 9:19 PM

I have a case of crossing node links:

The rest of the comments are inline. I think this will end up being the last or second-to-last review pass.

source/blender/editors/space_node/node_draw.c
505	Just make this a float, it's only used as one
506–511	This can be written more simply: if (nsock->flag & SOCK_MULTI_INPUT) { if (nsock->total_inputs > 2) { multi_input_socket_offset = (nsock->total_inputs - 2) * NODE_MULTI_INPUT_LINK_GAP; } } Also, at first I thought this code was to make the label start half-way down the bar, but this actually just accounts for the size of the socket. This is not obvious, there should be some brief comment describing this.
512	Values for floats should have an f at the end, like `0.5f`, or `0.0f`
772	const
773	`so wie must compensate for the outline width.` -> `so compensate for the outline width.`
1115	Unnecessary white-space change.
1162	Sure, that's obvious. The comments should explain why, not what.
1673	No need to abbreviate: `tmp` -> `temporary`
1696	`struct` is unecessary
1779–1782	`BLI_addtail(&multi_input_socket_links, MEM_dupallocN(linkdata));` should work here, like above.
1799–1800	I'm going to suggest changing this block of code a fair amount. To my eyes it's much more complex than it needs to be: Here's my suggestion. Much simpler and requires much fewer memory allocations. LISTBASE_FOREACH (bNode , node, &ntree->nodes) { LISTBASE_FOREACH (struct bNodeSocket , sock, &node->inputs) { if (sock->flag & SOCK_MULTI_INPUT) { /* This is calculated in #node_update_nodetree, which runs before the draw step. / const int total_inputs = sock->total_inputs; bNodeLink input_links = MEM_malloc_arrayN(total_inputs, sizeof(bNodeLink ), __func__); int index = 0; LISTBASE_FOREACH (bNodeLink , link, &ntree->links) { if (link->tosock == sock) { input_links[index] = (bNodeLink )link; index++; } } LISTBASE_FOREACH (bNodeLinkDrag , nldrag, &snode->runtime->linkdrag) { LISTBASE_FOREACH (LinkData , linkdata, &nldrag->links) { bNodeLink link = (bNodeLink )linkdata->data; if (link->tosock == sock) { input_links[index] = (bNodeLink )link; index++; } } } qsort(input_links, total_inputs, sizeof(bNodeLink ), cmp_link_by_angle_to_node); for (int i = 0; i < total_inputs; i++) { input_links[i]->multi_input_socket_index = i; } MEM_freeN(input_links); } } } This also requires a change to the comparison function, it should start with const bNodeLink link_a = (const bNodeLink *)a; const bNodeLink link_b = (const bNodeLink *)b;
source/blender/editors/space_node/node_edit.c
1126	Just put the function up here, no need for a prototype.
1126	`const float cursor[2]`
1196	Calculate the height above once, then assign it here.
source/blender/editors/space_node/node_relationships.c
29	Also not necessary to include this, at least it compiled for me without it.
42–50	Yes, it compiles, so it's a valid cleanup, but I don't see why you're removing the two of these here.
45	Not necessary anymore.
184	It's surprising to me that this has to be called in so many places. I think you could get away with removing a call to this in a couple places. Also, the argument is too high-level, I would make the argument a `ListBase` of links probably.
187	I've mentioned this a few times by now, if the loop doesn't remove or add a link, the `_MUTABLE` suffix is not needed. If my comments don't make sense, please ask. Otherwise I'd generally expect you to apply them more generally than just the specific line I commented on.
192	This function is mostly a duplicate of the code near line 900. I only looked at it briefly, but do you think should be shared?
205	`calloc` already sets this to NULL, no need to clear it. I know this is copied code.
246	Maybe use `NODE_LINK_RESOL` instead of a separate define.
276	How does this change the behavior? I turned it off and didn't notice difference.
837	Unrelated white-space change
903	Unrelated white-space change
1099	Watch your merge conflicts next time, this was removed in rBfec6a4e24ad3: Cleanup: don't end description with dot
source/blender/makesdna/DNA_node_types.h
147	Use the previous padding bytes earlier in the struct. Also, this should have a comment: `/* Runtime-only cache of the number of input links, for multi-input sockets. */`, or something like that. Also, to enforce the "runtime only" idea, this can be explicitly cleared in `direct_link_node_socket`.
396	Should have a comment like I mentioned for `total_inputs` Something like: `/* A runtime storage for automatically sorted links to multi-input sockets. */

This revision now requires changes to proceed.Feb 10 2021, 1:42 AM

Changes based on Review by Hans Goudey.

Harbormaster completed remote builds in B12798: Diff 33844.Feb 10 2021, 11:57 PM

Fabian Schempp (fabian_schempp) marked 2 inline comments as done.Feb 10 2021, 11:58 PM

Fabian Schempp (fabian_schempp) added inline comments.

source/blender/editors/space_node/node_relationships.c
184	It's surprising to me that this has to be called in so many places. I think you could get away with removing a call to this in a couple places. Also, the argument is too high-level, I would make the argument a `ListBase` of links probably.
187	I've mentioned this a few times by now, if the loop doesn't remove or add a link, the `_MUTABLE` suffix is not needed. If my comments don't make sense, please ask. Otherwise I'd generally expect you to apply them more generally than just the specific line I commented on. Sorry, I assume that this is not a new change otherwise I would have known by now.
276	It is possible that you drag and while you are dragging, into the right direction, your cursor leaves the intersection with the link you picked, which results in not picking the link. I found that this can feel a bit wired.

Fabian Schempp (fabian_schempp) marked an inline comment as done.Feb 10 2021, 11:59 PM

This looks pretty good to me. I'm tweaking some things and doing some cleanup, but I'll commit in a few minutes.

This revision is now accepted and ready to land.Feb 11 2021, 7:14 AM

Closed by commit rB8f707a72e818: UI: Multi-input node socket spacing and interaction (authored by Fabian Schempp (fabian_schempp), committed by Hans Goudey (HooglyBoogly)). · Explain WhyFeb 11 2021, 8:16 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB8f707a72e818: UI: Multi-input node socket spacing and interaction.

Done! Thanks again for working on this Fabian, I think the results are so awesome.

To see what I tweaked in the committed version you can select the diff between your last update and the commit here:

Commit	Tree	Parents	Author	Summary	Date
6b2407290e52	8cbeeea54f73	e85ab1ca1ea3	fabian_schempp	Made Multi Input Sockets drawing using UI_draw_roundbox	Feb 5 2021, 12:08 PM
e85ab1ca1ea3	a79a87d6aa02	875cd042e7af	fabian_schempp	Made Multi Input Sockets drawing using draw_roundbox	Feb 5 2021, 10:58 AM
875cd042e7af	6218e2910aef	75d6c024678c	fabian_schempp	Removed unneeded changes.	Feb 5 2021, 8:52 AM
75d6c024678c	7194062aa158	067caa249814	fabian_schempp	Made Drag Link update Socket and Node on Snap.	Feb 4 2021, 9:55 PM
067caa249814	8c4710f3e20e	c7224b0b949b	fabian_schempp	Made Drag Link update Socket and Node on Snap.	Feb 4 2021, 9:45 PM
c7224b0b949b	7de5e4394bd3	9ad530c09fc7	fabian_schempp	Fixed memoryleak by using BLI_freelinkN instad of BLI_remlink.	Feb 4 2021, 5:25 PM
9ad530c09fc7	d685d54d70f4	d2fd6185116f	fabian_schempp	Changed treshhold in shader to make edge a bit more smooth, based on Review by… (Show More…)	Feb 4 2021, 12:03 AM
d2fd6185116f	9d3427b7d06b	13bdedc20905	fabian_schempp	Changed link preselection highlighting color to use Theme Selected Color… (Show More…)	Feb 3 2021, 11:45 PM
13bdedc20905	db6b26ddd12b	df192e42f71c	fabian_schempp	Changes based on Review by Hans Goudey.	Feb 2 2021, 9:59 PM
df192e42f71c	0b7f4d91be92	c92b06760deb	fabian_schempp	Changed the link sorting method back to angle compare.	Feb 1 2021, 11:07 PM
c92b06760deb	a319adcaf59f	4c7596822886	fabian_schempp	Fixed ASAN error	Jan 30 2021, 11:14 PM
4c7596822886	ec91a8f01909	91ac1853dbc9	fabian_schempp	Fix to the layout with centered labels.	Jan 29 2021, 11:11 PM
91ac1853dbc9	2da9529a93cf	f0be94a91fc3	fabian_schempp	Reverted format changes to node_util.c	Jan 29 2021, 12:00 AM
f0be94a91fc3	a9fbab360ec0	51e1ff996167	fabian_schempp	Reverted changes to node_geo_join_geometry because they belong to another… (Show More…)	Jan 28 2021, 11:52 PM
51e1ff996167	29baf2cfb834	a8778c3164bd	fabian_schempp	Changed socket label to be centered vertically.	Jan 28 2021, 11:47 PM
a8778c3164bd	5c555a8640dc	3a7015255672	fabian_schempp	Removed working comments.	Jan 28 2021, 9:35 PM
3a7015255672	f821876e0c5f	ddffa05c54cf	fabian_schempp	Removed unused if block.	Jan 28 2021, 9:30 PM
ddffa05c54cf	c14ada329447	479b5150a27c	fabian_schempp	Changes based on review by Hans Goudey.	Jan 28 2021, 9:27 PM
479b5150a27c	f6427a9642ae	2ffe4270c532	fabian_schempp	Removed unnused shader binding that causes an assert.	Jan 27 2021, 9:45 PM
2ffe4270c532	9e613e44a90b	e6345e669cf7	fabian_schempp	Reverted unneeded changes in node_relationships.c.	Jan 27 2021, 11:30 AM
e6345e669cf7	fe8e45a3dd6f	59429c3f2bf0	fabian_schempp	Changes based on the revision from Hans Goudey	Jan 17 2021, 12:32 AM
59429c3f2bf0	eab2b0d3f910	476ea7037e98	fabian_schempp	Reverted some changes that belong to virtual socket color branch.	Jan 27 2021, 12:38 PM
476ea7037e98	5ab4b2e59fe2	59451ac86553	fabian_schempp	free cloned Listbase after use	Jan 27 2021, 10:02 AM
59451ac86553	06f59eff3f7a	e08b6d9e0dfa	fabian_schempp	Applied clang format.	Jan 24 2021, 8:33 PM
e08b6d9e0dfa	8144c2587e6a	6a33f4fb0837	fabian_schempp	Geometry Nodes: Socket Growing and Link Spaceing (Show More…)	Jan 23 2021, 12:57 AM
6a33f4fb0837	711064174f02	f9edae26afec	fabian_schempp	cleanup	Jan 23 2021, 12:05 AM
f9edae26afec	e0bab0e29c5c	3a47be3c74dc	fabian_schempp	make sockets only take one link from the same output socket.	Jan 22 2021, 8:54 AM
3a47be3c74dc	80d7e110ba15	7bb2f78b3260	fabian_schempp	better link picking by intersection	Jan 22 2021, 8:08 AM
7bb2f78b3260	00c9f2935a6a	fb263c491770	fabian_schempp	better link picking by intersection	Jan 22 2021, 2:08 AM
fb263c491770	0f3c71f22957	774dda432c62	fabian_schempp	updated node channel height update and mouse pick radius	Jan 21 2021, 1:07 AM
774dda432c62	400342275594	bf49548f82ca	fabian_schempp	updated shader and node drawing	Jan 20 2021, 11:48 PM
bf49548f82ca	7d85103f4b16	d41578fd527c	fabian_schempp	Geometry Nodes: spread input links	Jan 18 2021, 11:24 AM
d41578fd527c	6131d6b1c061	3a114e1db9be	fabian_schempp	implemented some more changes based on review by Ankit Meel	Jan 12 2021, 7:00 PM
3a114e1db9be	ee85bcae7b77	cb372c09ab5d	fabian_schempp	changed nameing of variable sock to sock_idname to fit better	Jan 12 2021, 11:14 AM
cb372c09ab5d	d096ea7a2e6b	3c29a8f09d98	fabian_schempp	Changes based on review by Ankit Meel	Jan 12 2021, 11:07 AM
3c29a8f09d98	8a47df21e314	374f486e75d7	fabian_schempp	Nodes: Changed the drawing of Virtual Sockets to be better recognizable. (Show More…)	Jan 10 2021, 8:48 PM
374f486e75d7	5dac84478b1d	7d895ff04848	fabian_schempp	changed default color for virtual inputs	Jan 10 2021, 8:49 PM
7d895ff04848	a681cd736087	b1fc0d87fd0b	fabian_schempp	display Multi Input Socket as circle if node is collapsed.	Jan 16 2021, 1:59 AM
b1fc0d87fd0b	5de550332f37	531c3ceb4813	fabian_schempp	merged missing pieces	Jan 7 2021, 10:25 PM
531c3ceb4813	a681cd736087	73706588459a	fabian_schempp	rebased onto master	Jan 16 2021, 1:59 AM
73706588459a	d4f16623434e	152b4b43c8dd	fabian_schempp	Geometry Nodes: Replaces the GPU_SHADER_KEYFRAME_DIAMOND with… (Show More…)	Jan 10 2021, 8:48 PM
152b4b43c8dd	bbbbe3d3b08e	85a026516d0e	fabian_schempp	merged missing pieces	Jan 7 2021, 10:25 PM
85a026516d0e	c9d8404ca6e7	cf75ac1baff3	fabian_schempp	make shader for elongated sockets work	Jan 9 2021, 3:28 AM
cf75ac1baff3	95958ceea94e	1f7d2856058a	fabian_schempp	replaceing the GPU_SHADER_KEYFRAME_DIAMOND with its native… (Show More…)	Jan 7 2021, 10:25 PM
1f7d2856058a	96aa3a413091	6177868d3453	fabian_schempp	Geometry Nodes: Added preselection highlighting to gesture based link picking… (Show More…)	Jan 17 2021, 8:41 AM
6177868d3453	45d07e96a717	114c02912181	fabian_schempp	Changed join_component_type() to use extracted multi input vector directly. (Show More…)	Jan 19 2021, 11:16 PM
114c02912181	030ea2f19d5f	add485ae0c18	fabian_schempp	changes based on review by Jacques Lucke	Jan 18 2021, 11:57 PM
add485ae0c18	7d00fccbf922	8990d09c462a	fabian_schempp	make multi input sockets displayed as diamond shape for now (Show More…)	Jan 11 2021, 3:53 AM
8990d09c462a	90add47d875d	d975073232bb	fabian_schempp	Geometry Nodes: changed Join Geometry Node to use multi input socket	Jan 10 2021, 10:35 PM
d975073232bb	8068f26a7883	9246d4606b8c	fabian_schempp	Geometry Nodes: Added preselection highlighting to gesture based link picking… (Show More…)	Jan 17 2021, 8:41 AM
9246d4606b8c	06253fd201c7	ee85e62c6fab	fabian_schempp	Geometry Nodes: Preselection highlighting for gesture based link picking for… (Show More…)	Jan 17 2021, 8:41 AM
ee85e62c6fab	bea2b7d0eca0	87e0beb5a91b	fabian_schempp	Changes based on the revision from Hans Goudey	Jan 17 2021, 12:32 AM
87e0beb5a91b	06253fd201c7	21560f8252c2	fabian_schempp	added missing line after merge	Jan 17 2021, 10:27 AM
21560f8252c2	fb6b15ab9635	9cc10b1603ba	fabian_schempp	added missing line after merge	Jan 17 2021, 10:25 AM
9cc10b1603ba	45ef317ace17	766e5b37126a	fabian_schempp	Geometry Nodes: Preselection highlighting for gesture based link picking for… (Show More…)	Jan 17 2021, 8:41 AM
766e5b37126a	dd953ac4ab46	f3fe264dd7aa	fabian_schempp	Changes based on the revision from Hans Goudey	Jan 17 2021, 12:32 AM
f3fe264dd7aa	eb44dd6eaa81	79a6dc76cc97	fabian_schempp	Geometry Nodes: Adds the option to make a node socket take multiple input links. (Show More…)	Jan 11 2021, 3:38 AM
79a6dc76cc97	4e03fd0818ea	165240c9f10f	fabian_schempp	Changes based on review by Hans Goudey.	Feb 2 2021, 8:02 PM
165240c9f10f	d2aa8d056be8	969976b52959	fabian_schempp	Changes based on review by Jacques Lucke.	Jan 29 2021, 9:29 PM
969976b52959	95df72abaec2	bae7fb84b336	fabian_schempp	Fixed another Typo in a comment block.	Jan 28 2021, 11:55 AM
bae7fb84b336	77645bdb15dc	f177caab783c	fabian_schempp	Applied clang format.	Jan 24 2021, 8:42 PM
f177caab783c	a765f72e80a1	3aa5e15963fb	fabian_schempp	Changes based on the review of Jacques Lucke.	Jan 19 2021, 10:02 PM
3aa5e15963fb	a7b27a2ad7d7	0567ad49205e	fabian_schempp	changes based on review by Jacques Lucke	Jan 18 2021, 11:37 PM
0567ad49205e	361ade42daf9	c40dfca8a7db	fabian_schempp	Changes based on the revision from Hans Goudey	Jan 17 2021, 10:04 AM
c40dfca8a7db	532c34c74c6a	80e3a560e6dc	fabian_schempp	Changes based on the revision from Hans Goudey	Jan 17 2021, 12:32 AM
80e3a560e6dc	f92d2e3957cb	9cd3424787e4	fabian_schempp	cleanup: removed an accidentally merged piece in node_draw.c	Jan 11 2021, 4:40 AM
9cd3424787e4	0057de2814fe	090d054d800b	fabian_schempp	cleanup: removed accidentally committed changes to FN_generic_pointer.hh	Jan 11 2021, 4:30 AM
090d054d800b	a8e29a26617e	44f7d64db350	fabian_schempp	Geometry Nodes: Adds the option to make a node socket take multiple input links. (Show More…)	Jan 11 2021, 3:38 AM
44f7d64db350	5174d21c472f	3d0210aa78f1	fabian_schempp	merged changes	Jan 7 2021, 10:49 PM
3d0210aa78f1	9a82a94ddca4	f0a0dc2ca1a4	fabian_schempp	merged missing pieces	Jan 10 2021, 8:14 PM
f0a0dc2ca1a4	19fcae7036b0	bfb3cc2273f1	fabian_schempp	merged stashed changes for multi input sockets	Jan 10 2021, 8:15 PM
bfb3cc2273f1	ce7aeb16105a	da20edd830a4	fabian_schempp	put angle_distance function for node link picking in math_base.c	Jan 10 2021, 10:05 PM
da20edd830a4	a71eb74da6b9	15838f7e8ed4	fabian_schempp	code cleanup for multi input sockets	Jan 10 2021, 11:20 AM
15838f7e8ed4	4e03fd0818ea	7bf25bce70e9	fabian_schempp	removed diamondshape and put it into shader commit	Jan 11 2021, 1:14 AM
7bf25bce70e9	7b69b7d935e7	fec6a4e24ad3	fabian_schempp	make multi input sockets displayed as diamond shape for now	Jan 7 2021, 11:01 PM

UI: Multi-input node socket spacing and interaction
ClosedPublic
Actions

Details