Page MenuHome
Differential D10192

Fix T79922: Cache of meta strip not invalidated
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jan 25 2021, 10:57 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T79922: Sequencer: Prefetched cache first image not refreshed when image path is changed by script
Commits
rBc9672084601e: Fix T79922: Cache of meta strip not invalidated
Summary

Meta strip cache is not invalidated if strip inside of meta strip is
invalidated.

Find all metastrips that contain invalidated strip and invalidate them
recursively.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D10192 (branched from master)
Build Status
Buildable 12384
Build 12384: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) created this revision.Jan 25 2021, 10:57 AM
Harbormaster completed remote builds in B12360: Diff 33100.Jan 25 2021, 10:57 AM
Richard Antalik (ISS) requested review of this revision.Jan 25 2021, 10:57 AM
Sergey Sharybin (sergey) added inline comments.Jan 25 2021, 11:21 AM
source/blender/sequencer/intern/strip_relations.c
146–151

Seems like the code will not work correct if there are multiple metas which contain invalidated_seq.

Richard Antalik (ISS) marked an inline comment as done.Jan 25 2021, 12:37 PM
Richard Antalik (ISS) added inline comments.
source/blender/sequencer/intern/strip_relations.c
146–151

That must never happen - it is forbidden by design

Sergey Sharybin (sergey) added a comment.Jan 25 2021, 2:51 PM

One thing i've missed in the original comment, why SEQ_relations_invalidate_cache_in_range does not invalidate metas?

source/blender/sequencer/intern/strip_relations.c
146–151

Ah, right. Got confused with something else.

Richard Antalik (ISS) updated this revision to Diff 33136.Jan 26 2021, 9:21 AM
Richard Antalik (ISS) marked an inline comment as done.
  • Invalidate metas also with SEQ_relations_invalidate_cache_in_range
Harbormaster completed remote builds in B12384: Diff 33136.Jan 26 2021, 9:21 AM
Sergey Sharybin (sergey) accepted this revision.Jan 26 2021, 9:50 AM
This revision is now accepted and ready to land.Jan 26 2021, 9:50 AM
Closed by commit rBc9672084601e: Fix T79922: Cache of meta strip not invalidated (authored by Richard Antalik (ISS)). · Explain WhyJan 26 2021, 5:52 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBc9672084601e: Fix T79922: Cache of meta strip not invalidated.

Revision Contents
Changeset List

PathSize
source/
blender/
sequencer/
intern/
35 lines

Diff 33136

View Options

source/blender/sequencer/intern/strip_relations.c

Loading...