Differential D10193

Fix T84907: Incorrect dirty mask after geometry join node.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 25 2021, 1:05 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T84907: Incorrect shading when using boolean node in Geometry Nodes modifier

Commits

rB4935ed6ce6b3: Fix T84907: incorrect dirty mask after geometry join node

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Jan 25 2021, 1:05 PM

Harbormaster completed remote builds in B12363: Diff 33105.Jan 25 2021, 1:05 PM

Jacques Lucke (JacquesLucke) requested review of this revision.Jan 25 2021, 1:05 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Jan 25 2021, 1:06 PM

Jacques Lucke (JacquesLucke) added a task: T84907: Incorrect shading when using boolean node in Geometry Nodes modifier.

The fix makes sense.

Looking into it a bit further, the flags are a bit funny, they're only used for normals now, I guess the idea is they could be used for something else in the future. Not sure what though, and of course there are no comments. The edge flag isn't even used anywhere. Anyway..

Hans Goudey (HooglyBoogly) accepted this revision.Jan 25 2021, 9:14 PM

This revision is now accepted and ready to land.Jan 25 2021, 9:14 PM

Closed by commit rB4935ed6ce6b3: Fix T84907: incorrect dirty mask after geometry join node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 26 2021, 12:10 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB4935ed6ce6b3: Fix T84907: incorrect dirty mask after geometry join node.