Fix T85051: Add bisect distance as a parameter to the mirror modifier
AbandonedPublic
Actions

Authored by Falk David (filedescriptor) on Jan 25 2021, 11:55 PM.

Details

Reviewers

Maniphest Tasks

T85051: Mirror modifier bug - Bisect mode results in “automerge” even if it shouldn’t. Most likely due to units setup put to cm.

Summary

The bisect_distance in the mirror modifier was hardcoded to 0.001.
This would result in some unexpected behaviour like vertices close
to the mirror plane being deleted or merged.

The fix changes the distance to 1e-7 to avoid any unintentional
"merging".

EDIT: The fix now adds a parameter to the mirror modifier to expose the
bisect distance to the user. The default is set to the previous hardcoded
value to not "change" previous files.

Diff Detail

Repository

rB Blender

Branch

T85051 (branched from master)

Build Status

Buildable 14002
Build 14002: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Jan 25 2021, 11:55 PM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B12373: Diff 33120.Jan 25 2021, 11:55 PM

Falk David (filedescriptor) added a reviewer: Campbell Barton (campbellbarton).Jan 26 2021, 10:40 AM

Falk David (filedescriptor) added a project: Modifiers.

Changing this epsilon could negatively impact larger models.

This should be made a user configurable setting, similar to the current mirror threshold.

This revision now requires changes to proceed.Jan 28 2021, 9:08 PM

Add bisect distance parameter to mirror modifier

Harbormaster completed remote builds in B13316: Diff 34869.Mar 8 2021, 11:48 AM

Falk David (filedescriptor) retitled this revision from Fix T85051: Too big bisect threshold to Fix T85051: Add bisect distance as a parameter to the mirror modifier.Mar 8 2021, 11:50 AM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)