Differential D10221

NLA: Refactor Transition, Use Snapshot Blend Func
ClosedPublic
Actions

Authored by Wayde Moss (GuiltyGhost) on Jan 27 2021, 6:40 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Group Reviewers

Animation & Rigging

Commits

rB10e23fd1046a: NLA: Refactor Transition, Use Snapshot Blend Func

Summary

The function nlastrip_evaluate_transition() has been slightly modified to use nlasnapshot_blend() instead of it's own special blending function nlaeval_snapshot_mix_and_free().

Depends on D10220: NLA: Extract nlasnapshot_blend() in order to compile.
No user functional changes

Diff Detail

Repository: rB Blender

Event Timeline

Wayde Moss (GuiltyGhost) requested review of this revision.Jan 27 2021, 6:40 AM

Wayde Moss (GuiltyGhost) created this revision.

Harbormaster completed remote builds in B12409: Diff 33196.Jan 27 2021, 6:40 AM

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Jan 27 2021, 7:17 AM

Wayde Moss (GuiltyGhost) added reviewers: Sybren A. Stüvel (sybren), Animation & Rigging.

Wayde Moss (GuiltyGhost) added a project: Animation & Rigging.

Wayde Moss (GuiltyGhost) updated this revision to Diff 33199.Jan 27 2021, 8:05 AM

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)

proper rebase since dependency patch accepted.

Harbormaster completed remote builds in B12586: Diff 33510.Feb 3 2021, 10:57 PM

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)Feb 3 2021, 10:58 PM

LGTM. The separation of blending and freeing the memory also makes me happy ;)

This revision is now accepted and ready to land.Feb 5 2021, 12:24 PM

Closed by commit rB10e23fd1046a: NLA: Refactor Transition, Use Snapshot Blend Func (authored by Wayde Moss (GuiltyGhost)). · Explain WhyFeb 5 2021, 11:00 PM

This revision was automatically updated to reflect the committed changes.

Wayde Moss (GuiltyGhost) added a commit: rB10e23fd1046a: NLA: Refactor Transition, Use Snapshot Blend Func.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

anim_sys.c

65 lines

nla_private.h

2 lines

Diff 33653

View Options

source/blender/blenkernel/intern/anim_sys.c