Page MenuHome

Nodes: Move the "Group Input" and "Group Output" nodes to consistent menu location
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jan 28 2021, 10:25 PM.

Details

Summary

Currently (in geometry nodes) you can delete the group input or group output nodes with no
way to get them back without copy and paste. This adds them to the
"Group" submenu of the add menu so at least there is a way to add them back.

Additionally, these nodes are moved to the "Group" submenu for all node editors.
This makes sense since they are not like the other input or output nodes, they
really just relate to how nodes are organized in groups.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jan 28 2021, 10:25 PM
Hans Goudey (HooglyBoogly) created this revision.

I wonder if the categories are correct. Those are not Layout items. I would either have them in Group or in Input/Output categories. For the records, for shaders the Material Output is in the output category.

Also another option is for the poll function to only let you create the nodes if there is no node of its type there.

I agree with Dalai here that they should be under Input and Output respectively.

Currently, having more than one Group Output node disables the whole tree. Could it be made to only use the active Group Output node, like Material Output does?

I agree with Dalai here that they should be under Input and Output respectively.

To be clear, we have no "Output" category in geometry nodes right now, are you suggesting adding one?

Currently, having more than one Group Output node disables the whole tree. Could it be made to only use the active Group Output node, like Material Output does?

I think this situation is a bit different, since these are just node groups. We could add the idea of an active node group output, but as far as I know we had some different designs for how node groups could be improved already.

I talked to @Hans Goudey (HooglyBoogly) and we both think it could be in Group. @Pablo Vazquez (pablovazquez) do you have any big objection with that? I personally find a bit strange to have the Output category that we won't really be using much

I don't mind either way.

Let's go with adding these into the Group category.

These nodes should be moved from Input/Output to Group for Shading, Texture, and Compositor nodes as well.

  • Merge branch 'master' into geometry-nodes-input-output-nodes
  • Move to "Group" category for all node editors
Hans Goudey (HooglyBoogly) retitled this revision from Geometry Nodes: Add "Group Input" and "Group Output" nodes to menu to Nodes: Move the "Group Input" and "Group Output" nodes to consistent menu location.Mar 5 2021, 9:22 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 11 2021, 3:53 PM