Differential D10242
Fix for T84038: Improved Report Warnings Authored by Harley Acheson (harley) on Jan 28 2021, 11:53 PM.
Details
This patch consolidates the drawing of report icons so that footer warnings match how they look in the Info Editor. Once applied, they should look like the following. Obviously the left side is the default "Dark" theme, while right side is with updated "Light" theme. 
Diff Detail
Event TimelineComment Actions Code-wise the consolidation seems great. I think one visual issue is that in general the reports don't stand out as much. It's easier not to notice them while focused on something else.  I guess you mixed in some of the text color with the icon background color. I'm not sure about that one, especially for the yellow icon, which becomes quite hard to read.  I don't have any great idea, but maybe there's a way to make them "pop" a bit more. Comment Actions
Yes, there is definitely less impact, although I have a hard time judging how much people want there.
No, for the background of the text I mixed bit of the text color into the area background color so that part stands out a bit from the rest. however, as far as I was trying for the yellow in the warning icon should be same in both places and it clearly is not. So will have to investigate.
Yes, I'm sure I can figure something out. Comment Actions The color difference is in Info Editor: The following shows the colors as defined in Preferences, then how they are coming out on the status bar, versus in Info Editor.  This will (probably) be that Info Editor is using the old roundbox_aa that isn't fully opaque. It would obviously be easier to leave things as they are and just make statusbar alert colors have a similar opacity. But in the end of the day I'd rather things look as they are defined in Properties, so I'd rather fix it properly, make both things show exactly as they are in the theme and update those so that they visual match what we see today. Comment Actions All icons showing with same strength in statusbar, Info, as in Properties. Updating the themes to compensate. Using a small part of the icon color to tint the main message area. Will update the first comment with sample. Comment Actions
I a bit constrained by having to use the layout system here. On the left side I can use any background color and can also color the icon itself anything as well. But the text on the right needs to be in the text color of that region. And the embossing is a (strange) requirement to get the background coloring. Comment Actions This looks great Harley, nice job. It looks a lot better, much more readable, and is nicely consistent with the info editor. And it even cleans up code too!
Comment Actions Updated to current state of master and to clean up / improve comments.
Yes, I added a comment there. You would only see a difference if you changed the theme colors. Right now they are all black or white on a colored background, but that icon color could be anything at all really. This is done directly in Info Editor, but in layout I have to allow but->col to override the icon color in the same way we do for UI_BTYPE_ROUNDBOX, otherwise it is text color. We might be able to commit this. But I'd be happier if someone else could eyeball the colors that I arbitrarily changed. These had to be touched because the icons in Info Editor were not full opacity so the background color bled through. Now what you see in Properties is what you get elsewhere. Following is are the relevant theme colors, left Default and right is "Light".  | ||||||||||||