Page MenuHome
Differential D10252

Fix T85203: GPencil: Drawing on locked axis plane
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Jan 29 2021, 5:43 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Maniphest Tasks
T85203: GPencil: Projection to axis (like XZ plane) is no longer working
Commits
rB006e70dbd7e2: Fix T85203: GPencil: Drawing on locked axis plane
Summary

Drawing on e.g. the X-Z plane was broken due to an earlier
commit (rBef28da262342). This was causing the projection when drawing
on an axis plane to fail.

The fix checks that the user is in view plane projection mode.

Diff Detail

Repository
rB Blender
Branch
T85203 (branched from master)
Build Status
Buildable 12477
Build 12477: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Jan 29 2021, 5:43 PM
Falk David (filedescriptor) created this revision.
Falk David (filedescriptor) added a reviewer: Antonio Vazquez (antoniov).Jan 29 2021, 5:44 PM
Falk David (filedescriptor) added a project: Grease Pencil.
Harbormaster completed remote builds in B12477: Diff 33317.Jan 29 2021, 5:44 PM
Antonio Vazquez (antoniov) added inline comments.Jan 29 2021, 8:24 PM
source/blender/editors/gpencil/gpencil_fill.c
1159

Are you sure you need change is_camera? Test in different modes in camera view to be sure we don't break anything.

Antonio Vazquez (antoniov) accepted this revision.Feb 1 2021, 4:24 PM
This revision is now accepted and ready to land.Feb 1 2021, 4:24 PM
Closed by commit rB006e70dbd7e2: Fix T85203: GPencil: Drawing on locked axis plane (authored by Falk David (filedescriptor)). · Explain WhyFeb 1 2021, 4:27 PM
This revision was automatically updated to reflect the committed changes.
Falk David (filedescriptor) added a commit: rB006e70dbd7e2: Fix T85203: GPencil: Drawing on locked axis plane.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
7 lines
12 lines
6 lines

Diff 33317

View Options

source/blender/editors/gpencil/gpencil_fill.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_paint.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_primitive.c

Loading...