Page MenuHome

Fix incorrect variable scope in ridged multi-fractal noise
ClosedPublic

Authored by Robert Guetzkow (rjg) on Jan 30 2021, 1:30 PM.

Details

Summary

This patch fixes T85225 introduced in rB74188e65028d268af887ab2140e4253087410c1e. The commit incorrectly moved the declaration and intialization of the variable pwr inside the loop. Since the value was originally modified in each iteration based on it's previous value and pwHL through pwr *= pwHL, this change in scope is wrong. It resets the value in each iteration. This patch moves the declaration of pwr outside the loop again.

Diff Detail

Repository
rB Blender
Branch
2021-01-30-noise (branched from master)
Build Status
Buildable 12493
Build 12493: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) requested review of this revision.Jan 30 2021, 1:30 PM
Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)Jan 30 2021, 1:31 PM
This revision is now accepted and ready to land.Feb 2 2021, 4:58 PM