Page MenuHome
Differential D10262

UI: Change "Favorites" to "Bookmarks"
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Jan 30 2021, 7:58 PM.

Details

Reviewers
Julian Eisel (Severin)
Group Reviewers
User Interface
Commits
rBa79c33e8f8f3: UI: Change "Favorites" to "Bookmarks"
Summary

This simple patch does nothing but change the heading for the File Browser section "Favorites" to "Bookmarks":

We currently use the term "bookmark" to describe these items all over the place, both internally (the name of the section, list, all accessor functions) and externally.

When there are no bookmarks we are NOW showing a big button to "Add Bookmark"

In current master, hover over the "+" to add a new one and the tooltip says "Add a Bookmark". You also "Remove Bookmark", "Move Bookmark", or select "Delete all invalid bookmarks" from the "Bookmarks Specials" menu.

So having the section heading call them "Favorites" is confusing when we are using "bookmarks" literally everywhere else.

The "Bookmark" term is a better cross-platform description of what these are. It matches the ubiquitous usage for the similar feature in web browsers. And linguistically it is a better fit as these aren't my favorites, they are just items I have specifically marked for easy retrieval later.

If we don't wish to make this small change to the heading, then the alternative is to change all the user-facing text to "favorite" consistently. That is done in D12458.

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Jan 30 2021, 7:58 PM
Harley Acheson (harley) created this revision.
Daniel Ulrich (dulrich) awarded a token.Jan 31 2021, 8:03 AM
Harley Acheson (harley) updated this revision to Diff 36242.Apr 17 2021, 3:12 AM

updating to current state of master.

stefano severi (Tetone) awarded a token.Apr 17 2021, 11:57 AM
Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Apr 19 2021, 4:17 PM
Harley Acheson (harley) updated this revision to Diff 38172.Jun 10 2021, 11:43 PM
Harley Acheson (harley) edited the summary of this revision. (Show Details)

Updated to current state of master.

Harley Acheson (harley) edited the summary of this revision. (Show Details)Jun 10 2021, 11:58 PM
Harley Acheson (harley) added a subscriber: Gilberto Rodrigues (gilberto_rodrigues).Sep 10 2021, 6:54 PM

@Gilberto Rodrigues (gilberto_rodrigues) :

Do you mind elaborating a bit? I am assuming from the "thumbs down" that you prefer this section to remain as "Favorites", rather than changing to "Bookmarks", so you would also want to change the current usages of "bookmark" to favorites as well? So "Add a Favorite", "Remove Favorite", "Move Favorite", "Delete all invalid Favorites", etc?

Gilberto Rodrigues (gilberto_rodrigues) added a comment.EditedSep 11 2021, 5:14 PM

Just my personal preference, no big deal. If majority prefers bookmarks, go for it! I think "Favorites" is simpler to translate. Edit: just noticed it's already written the equivalent word for "favorite" instead of "bookmark" in those tooltips depending language of blender.

Harley Acheson (harley) added a comment.Sep 11 2021, 5:40 PM
In D10262#324655, @Gilberto Rodrigues (gilberto_rodrigues) wrote:

Just my personal preference, no big deal. If majority prefers bookmarks, go for it! I think "Favorites" is simpler to translate.

Thanks! Just making sure. Although I personally prefer “Bookmark” by a small amount, I think it’s more important to make it consistent in there. One or the other is fine, but not a combination, especially when translated. Will make another patch that does instead.

Harley Acheson (harley) updated this revision to Diff 41705.Sep 11 2021, 6:17 PM

Updated to current state of master.

Harley Acheson (harley) edited the summary of this revision. (Show Details)Sep 11 2021, 7:06 PM
Evan Wilson (EAW) awarded a token.Sep 12 2021, 6:56 AM
Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Sep 12 2021, 7:22 AM

these aren't my favorites, they are just items I have specifically marked for easy retrieval later.

After considering both options, I am in favor of changing it to Bookmarks primarily for the reason stated above.

Julian Eisel (Severin) accepted this revision.Sep 20 2021, 1:03 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

We use Bookmark in all the tooltips, operator names, etc. So I think we should stick to that. We could decide to entirely switch to "Favorites" (like D12458: UI: Consistent Usage of "Favorite" suggests), but then we should probably also do the compatibility breaking change of updating operator and property names.

This is the simpler, non-compatibility breaking change, so accepting this.

This revision is now accepted and ready to land.Sep 20 2021, 1:03 PM
Closed by commit rBa79c33e8f8f3: UI: Change "Favorites" to "Bookmarks" (authored by Harley Acheson (harley)). · Explain WhySep 20 2021, 4:42 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rBa79c33e8f8f3: UI: Change "Favorites" to "Bookmarks".

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
2 lines

Diff 36242

View Options

release/scripts/startup/bl_ui/space_filebrowser.py

Loading...