Page MenuHome

CMake/Linux: Add libharu to platform_linux.cmake
ClosedPublic

Authored by Ankit Meel (ankitm) on Feb 1 2021, 6:38 PM.

Details

Summary

Since GPencil changes depending on libharu may be committed to master
before SVN libraries for all platforms are in place, avoid build issues.
Extension of D9928.

Diff Detail

Repository
rB Blender
Branch
lin_haru (branched from master)
Build Status
Buildable 12524
Build 12524: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Feb 1 2021, 6:38 PM

Thanks for implementing this.

build_files/cmake/platform/platform_unix.cmake
479–483

This could use set_and_warn_dependency to avoid code duplication with macOS and be consistent with other libs.

479–483

To be clear, adding an entry for that in the toplevel CMakeLists.txt rather than handling the haru-tiff dependency here.

Ankit Meel (ankitm) marked 2 inline comments as done.
  • Remove duplicated code for haru-tiff dependency

set_and_warn_dependency: That's news!
Handled in master. rB33b8063b1fb4c96293bdea23509afd26e88ee833

This revision is now accepted and ready to land.Feb 9 2021, 2:29 PM