Page MenuHome
Differential D10281

cmake/deps: remove 'tcl' language support from sqlite
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Feb 1 2021, 11:33 PM.

Details

Reviewers
Bastien Montagne (mont29)
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Ray Molenkamp (LazyDodo)
Summary

Build sqlite without tcl support, as it's causes an error on installation when tcl is installed into the systems /usr/lib/ and install isn't running as root.

This could be resolves by adding tcl as a dependency however it's not needed for Python's sqlite integration.

Linux distributions (Debian & Arch at least) split this off into a separate package (which Python doesn't depend on), so there is no need for Blender to include sqlite's tcl integration either.

Currently make deps fails on my system, one of the errors I'm running into is sqlite fails to install.

The problem is that it's trying to install tcl language support into my system path.

/usr/bin/install: cannot change permissions of ‘/usr/lib/tcl8.6/sqlite3’: No such file or directory
make[4]: *** [Makefile:1350: tcl_install] Error 1

While the "correct" fix is to build our own local TCL, I can only assume other developers didn't already run into this because they don't have TCL installed.

Diff Detail

Repository
rB Blender
Branch
TEMP-DEPS-NO-TCL (branched from master)
Build Status
Buildable 12529
Build 12529: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Feb 1 2021, 11:33 PM
Campbell Barton (campbellbarton) created this revision.
Harbormaster completed remote builds in B12529: Diff 33408.Feb 1 2021, 11:33 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 1 2021, 11:52 PM
Campbell Barton (campbellbarton) added reviewers: Bastien Montagne (mont29), Sergey Sharybin (sergey), Brecht Van Lommel (brecht).
Campbell Barton (campbellbarton) added a project: Platforms, Builds, Tests & Devices.
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Feb 1 2021, 11:54 PM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) added a reviewer: Ray Molenkamp (LazyDodo).Feb 1 2021, 11:56 PM
Campbell Barton (campbellbarton) retitled this revision from cmake/deps: Sqlite: remove 'tcl' language dependency to cmake/deps: remove 'tcl' language dependency from sqlite.
Campbell Barton (campbellbarton) retitled this revision from cmake/deps: remove 'tcl' language dependency from sqlite to cmake/deps: remove 'tcl' language support from sqlite.
Campbell Barton (campbellbarton) mentioned this in D10282: cmake/deps: Update mesa to 20.3.4.Feb 2 2021, 1:19 AM
Brecht Van Lommel (brecht) accepted this revision.Feb 2 2021, 1:24 AM

I think this is the correct fix, we have a bunch of --disable flags like this to avoid accidentally picking up system packages that we do not need.

Should require no work from platform maintainers since presumably they do not have tcl installed and existing precompiled libraries are fine.

This revision is now accepted and ready to land.Feb 2 2021, 1:24 AM
Ray Molenkamp (LazyDodo) accepted this revision.Feb 2 2021, 3:22 AM

ideally make deps should write nothing outside its own build folder, if this does happen we ought to put a stop to that.

Campbell Barton (campbellbarton) mentioned this in rB3ae74bcd29c6: cmake/deps: remove 'tcl' language support from sqlite.Feb 2 2021, 9:17 AM
Campbell Barton (campbellbarton) closed this revision.Feb 2 2021, 10:11 AM

Committed, closing.

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
cmake/
2 lines

Diff 33408

View Options

build_files/build_environment/cmake/sqlite.cmake

Loading...