Page MenuHome

Fix T85396: Display Texture Paint UV only working in editmode
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Feb 5 2021, 10:51 AM.

Details

Summary

Caused by rBf83aa830cd00.

Since above commit, only meshes in editmode were considered for drawing
(because
BKE_view_layer_array_from_objects_in_edit_mode_unique_data_with_uvs was
used), but the option needs to work for texture paint mode as well, so
use BKE_view_layer_array_from_objects_in_mode_unique_data instead on
pass the draw_ctx->object_mode.

note: there is no good filter_fn to check if we have UVs if mesh is not
in editmode, this shouldnt cause much of a performance hit though.

Diff Detail

Repository
rB Blender
Branch
T85396 (branched from master)
Build Status
Buildable 12643
Build 12643: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Feb 5 2021, 10:51 AM
source/blender/draw/engines/overlay/overlay_edit_uv.c
406

Shouldn't it also check if the object is selected?

Jeroen Bakker (jbakker) added inline comments.
source/blender/draw/engines/overlay/overlay_edit_uv.c
406

We checked together that this can never be the case.

This revision is now accepted and ready to land.Feb 5 2021, 12:15 PM