Page MenuHome

Remove seq->tmp usage from transform code
ClosedPublic

Authored by Richard Antalik (ISS) on Feb 5 2021, 1:38 PM.

Details

Summary

This field was used for extend feature to get handle position of
metastrip children. Since D9972 extend feature works only on meta
strip itself, not it's children.
So SEQ_transform_get_left_handle_frame() second argument is always
false and can be removed.

Another instance of seq->tmp usage is hack to distinguish strips to be
shuffled, which is not covered by this patch.

Diff Detail

Repository
rB Blender
Branch
rm-seq-tmp-extend (branched from master)
Build Status
Buildable 12649
Build 12649: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Feb 5 2021, 1:38 PM

Oops uploaded rebased patch on D9972. Rebase on master instead.

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Feb 5 2021, 1:48 PM
  • remove TODO comment
  • Remove more seq->tmp usage

Revert last commit, seq->tmp usage there is bit more complicated. I thought that I have just forgot to remove it.

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Jun 4 2021, 2:10 AM
This revision is now accepted and ready to land.Jun 4 2021, 2:17 AM