Differential D10322
Cleanup: Use raw string literal Authored by Sergey Sharybin (sergey) on Feb 5 2021, 2:09 PM. Tags None Subscribers None
Details Resolves modernize-raw-string-literal Clang-Tidy warning The way warning works is it suggests to use raw literal when Not sure if this is something we really find better. Input is
Diff Detail
Event TimelineComment Actions I really don't see the need for this in HTML code. HTML can use both single and double quotes for arguments, so why not just use something like this? f << "<line fill='none' stroke='black' stroke-width='" << strokew << "' x1='" << SX(uco[0]) << "' y1='" << SY(uco[1]) << "' x2='" << SX(vco[0]) << "' y2='" << SY(vco[1]) << "'>\n"; "\\\\\\" → R"(\\\)" is a clear winner though! Comment Actions Wasn't there something in the strict HTML that it should be double quote? Is also not really HTML, but some gnuplot/graphviz dialect. You sure it works there? Is also from code cleanup point of view: doing those type of changes (" -> ') is not something I can call no-functional-changes as it changes the way Blender saves files. Not sure this is something I want to be looking into. But having R"(\\\)" and the warning enabled is something I want to. Comment Actions Even in the good old HTML 4 it was allowed to use either double or single quotes, to make it easier to have attribute values that have the other style of quotes in their value. See HTML 4 spec on SGML section 3.2.2. You're right to worry about graphviz, though. From their documentation:
So yeah, your patch is doing the right thing here. |