cmake/deps: update alembic to 1.7.16
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Feb 5 2021, 5:09 PM.

Details

Reviewers

Sebastián Barschkis (sebbas)
Sybren A. Stüvel (sybren)

Commits

rB649f99b6bc99: CMake/Deps: Alembic 1.7.16

Summary

straight forward version bump, the only thing significant is
that alembic was using boost to get shared/unique_ptr and
they are seemingly no longer CI'ing with ALEMBIC_LIB_USES_BOOST
so that gave build errors on both linux and windows.

after consulting with sybren it was decided that dropping the
boost dep and relying on the STL implementation will be the
way to go.

Diff Detail

Repository

rB Blender

Branch

tmp_alembic (branched from master)

Build Status

Buildable 12661
Build 12661: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Feb 5 2021, 5:09 PM

Ray Molenkamp (LazyDodo) created this revision.

Harbormaster completed remote builds in B12661: Diff 33622.Feb 5 2021, 5:09 PM

Ray Molenkamp (LazyDodo) mentioned this in T85365: Libraries Changes for Blender 2.93.Feb 5 2021, 5:10 PM

Sebastián Barschkis (sebbas) accepted this revision.Feb 5 2021, 5:11 PM

This revision is now accepted and ready to land.Feb 5 2021, 5:11 PM

@Ray Molenkamp (LazyDodo) On a second note, wouldn't it be nice to make this change explicit (-DALEMBIC_LIB_USES_BOOST=OFF)?

Obviously my bad, but I just had alembic fail on me because cmake was still referencing boost.

It shouldn't? but if you want to explicitly tell it not to that be fine with me

took a closer look, this flag is off by default?

Ah never mind, it builds as is it is right now and that counts.

Sybren A. Stüvel (sybren) accepted this revision.Feb 12 2021, 12:30 PM

Closed by commit rB649f99b6bc99: CMake/Deps: Alembic 1.7.16 (authored by Sybren A. Stüvel (sybren)). · Explain WhyFeb 15 2021, 12:17 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB649f99b6bc99: CMake/Deps: Alembic 1.7.16.

Revision Contents
Changeset List

Path

Size

build_files/

build_environment/

cmake/

alembic.cmake

11 lines

versions.cmake

4 lines

Diff 33622

View Options

build_files/build_environment/cmake/alembic.cmake