Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- warn (branched from master)
- Build Status
Buildable 12684 Build 12684: arc lint + arc unit
Event Timeline
Comment Actions
While I have nothing against this patch (I quite like it actually) however the patch description is highly unsatisfactory, please try at least a little , see The ingredients of a patch for the bare minimum we expect.
in said patch description you could have make the argument why WARNING
CMake Warning at CMakeLists.txt:728 (message): No dependencies need 'WITH_BOOST' forcing WITH_BOOST=OFF -- 'WITH_OPENVDB' is disabled: forcing 'set(WITH_NANOVDB OFF)' -- 64 bit compiler detected. -- Visual Studio 2019 detected. -- SSE2 SIMD instructions enabled -- Tests: Using Python executable: K:/BlenderGit/2019_full_tests/bin//2.93/python/bin/python$<$<CONFIG:Debug>:_d> -- Disabling sequencer render tests because OIIO idiff does not exist -- Configuring done -- Generating done -- Build files have been written to: K:/BlenderGit/2019_full_tests
would be preferred over STATUS
-- No dependencies need 'WITH_BOOST' forcing WITH_BOOST=OFF -- 'WITH_OPENVDB' is disabled: forcing 'set(WITH_NANOVDB OFF)' -- 64 bit compiler detected. -- Visual Studio 2019 detected. -- SSE2 SIMD instructions enabled -- Tests: Using Python executable: K:/BlenderGit/2019_full_tests/bin//2.93/python/bin/python$<$<CONFIG:Debug>:_d> -- Disabling sequencer render tests because OIIO idiff does not exist -- Configuring done -- Generating done -- Build files have been written to: K:/BlenderGit/2019_full_tests
I bet you had a good reason for making this change, but i'm not seeing it.
Comment Actions
I really think we should change WARNING back to STATUS. The console output from WARNING is messy and this was not done consistently (platform_apple.cmake was changed but not other platforms).
I don't see what that change achieves.