cleanup: fix source typos (API breakage)
ClosedPublic
Actions

Authored by luzpaz (luzpaz) on Feb 6 2021, 3:43 PM.

Details

Reviewers

Harley Acheson (harley)
Hans Goudey (HooglyBoogly)

Commits

rBf362dad19bf4: Cleanup: Source Code Typos

Summary

Follow-up to https://developer.blender.org/D10288
This patch contains code breaking changes. Please review closely.

Diff Detail

Repository: rB Blender

Event Timeline

luzpaz (luzpaz) requested review of this revision.Feb 6 2021, 3:43 PM

luzpaz (luzpaz) created this revision.

luzpaz (luzpaz) retitled this revision from cleanup to cleanup: fix source typos (API breakage).Feb 6 2021, 3:47 PM

luzpaz (luzpaz) edited the summary of this revision. (Show Details)

luzpaz (luzpaz) added reviewers: Aaron Carlisle (Blendify), Harley Acheson (harley).

These do look generally useful, but I'll add @Campbell Barton (campbellbarton) as I'm not sure how (or if) to proceed.

For things like these...

unit.c temperature unit 'CELCIUS'
sculpt_filter_color.c prop_color_filter_types 'BRIGTHNESS'

I don't know that we have a way to deprecate them nicely. We could alter the names and desc to indicate they are deprecated, ADD items that are properly spelled, then remove the deprecated ones in 3.0. But in the mean time both the old and new values would work and both show in lists. I think I'd rather add some "TODO: Fix in 3.0" comment to them though, but not sure how to not miss doing them at that time.

COM_KeyingNode.cpp 245 doesn't look right. the variable declared on 243 would also have to change.

Note that I didn't mean to "resign" as reviewer, hit the wrong button and now not sure how to "un-resign." LOL

CELCIUSwas added quite recently (by me, oops), and it's not used anywhere, and unlikely to be used by addons, so I doubt there's any problem changing it here.
Similarly, BRIGTHNESS is from an experimental feature (sculpt vertex colors), so no issue changing that one.

Harley Acheson (harley) accepted this revision.Feb 7 2021, 11:28 PM

This revision is now accepted and ready to land.Feb 7 2021, 11:28 PM

In D10347#260011, @Hans Goudey (HooglyBoogly) wrote:

CELCIUSwas added quite recently (by me, oops), and it's not used anywhere, and unlikely to be used by addons, so I doubt there's any problem changing it here.
Similarly, BRIGTHNESS is from an experimental feature (sculpt vertex colors), so no issue changing that one.

Those are the only ones that seemed problematic. Well except, for the one variable name in COM_KeyingNode.cpp

How to proceed...please advise? Shall I rebase ?

Harley Acheson (harley) edited reviewers, added: Hans Goudey (HooglyBoogly); removed: Aaron Carlisle (Blendify).Feb 13 2021, 6:05 PM